Skip to content

fix the export of modules#134

Merged
amtoine merged 6 commits intonightlyfrom
fix-manual-export
Dec 15, 2023
Merged

fix the export of modules#134
amtoine merged 6 commits intonightlyfrom
fix-manual-export

Conversation

@amtoine
Copy link
Copy Markdown
Owner

@amtoine amtoine commented Dec 9, 2023

depends on

description

as directory modules won't export the modules next to any mod.nu, this PR adds export module calls to nu-git-manager-sugar and the tests, making the source base compatible again with nushell/nushell#11157 and nushell/nupm#47.

@amtoine amtoine added fix A fix for a bug sugar Related to the `nu-git-manager-sugar` module wait-for-upstream Need to wait for an upstream project to push some changes. labels Dec 9, 2023
@amtoine amtoine marked this pull request as ready for review December 15, 2023 11:58
@amtoine amtoine marked this pull request as draft December 15, 2023 12:01
@amtoine amtoine changed the base branch from main to nightly December 15, 2023 12:01
@amtoine amtoine added the nightly A bleeding edge change label Dec 15, 2023
@amtoine amtoine force-pushed the fix-manual-export branch 3 times, most recently from 69dcab8 to 8bbdfeb Compare December 15, 2023 12:10
@amtoine
Copy link
Copy Markdown
Owner Author

amtoine commented Dec 15, 2023

(the force-pushes after the nightly label can be forgotten, i was just testing a bug in the CI 👀)

this will bring the new fixed CI from #139.
this should solve the merge conflict in #134 and bring the changes
from #140.
this will bring the changes from #141 and should fix the CI.
@amtoine
Copy link
Copy Markdown
Owner Author

amtoine commented Dec 15, 2023

(just did amend the last commit)

@amtoine amtoine marked this pull request as ready for review December 15, 2023 15:40
@amtoine amtoine merged commit 1262909 into nightly Dec 15, 2023
@amtoine amtoine deleted the fix-manual-export branch December 15, 2023 15:41
@amtoine amtoine mentioned this pull request Dec 16, 2023
amtoine added a commit that referenced this pull request Dec 16, 2023
follow-up to
- #134

## description
- `toolkit.nu` still contained `./src/`
- there was a bad `./src/nu-git-manager/mod.nu` introduced by
#134
amtoine added a commit that referenced this pull request Jan 21, 2024
depends on
- nushell/nushell#11157
- nushell/nupm#47
- #140
- #141

## description
as directory modules won't export the modules next to any `mod.nu`, this
PR adds `export module` calls to `nu-git-manager-sugar` and the tests,
making the source base compatible again with
nushell/nushell#11157 and
nushell/nupm#47.
amtoine added a commit that referenced this pull request Jan 21, 2024
follow-up to
- #134

## description
- `toolkit.nu` still contained `./src/`
- there was a bad `./src/nu-git-manager/mod.nu` introduced by
#134
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix A fix for a bug nightly A bleeding edge change sugar Related to the `nu-git-manager-sugar` module wait-for-upstream Need to wait for an upstream project to push some changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant