Allow option attribute for children of amp-selector in templates#9585
Merged
cvializ merged 1 commit intoampproject:masterfrom May 26, 2017
Merged
Allow option attribute for children of amp-selector in templates#9585cvializ merged 1 commit intoampproject:masterfrom
cvializ merged 1 commit intoampproject:masterfrom
Conversation
aghassemi
approved these changes
May 26, 2017
10xjs
added a commit
to metalabdesign/ampstart
that referenced
this pull request
Jul 14, 2017
Validation currently fails due to ampproject/amphtml#9536 (comment). ```html <amp-list> <template type="amp-mustache"> <amp-selector> <!-- `option` on the next line fails amp validation --> <div option="a">A<div> </amp-selector> </template> <amp-list> ``` Once ampproject/amphtml#9585 lands, this will no longer be a validation error.
10xjs
added a commit
to metalabdesign/ampstart
that referenced
this pull request
Jul 19, 2017
Validation currently fails due to ampproject/amphtml#9536 (comment). ```html <amp-list> <template type="amp-mustache"> <amp-selector> <!-- `option` on the next line fails amp validation --> <div option="a">A<div> </amp-selector> </template> <amp-list> ``` Once ampproject/amphtml#9585 lands, this will no longer be a validation error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Even though this change is in #9553, I want to merge this piece specifically to allow the workaround in #9536 to work.