Fix render-delaying-extension false error report#9382
Merged
jridgewell merged 3 commits intoampproject:masterfrom May 25, 2017
Merged
Conversation
673716a to
499534f
Compare
If the `opt_racePromise` resolved before the time, we would still get a timeout error since we never cancel it.
499534f to
3eca4ac
Compare
3eca4ac to
aa40884
Compare
Contributor
Author
|
Ping. |
alanorozco
approved these changes
May 25, 2017
jridgewell
added a commit
that referenced
this pull request
May 25, 2017
This reverts commit 330c3d8.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
render-delaying extensions use
#timeoutPromise, but#timeoutPromisewill always create an error once the timer completes. But, if theracePromisehas completed, there's no need for the timeout.Fixes #8011.