Doc tweaks for formatting & style + valid layouts on amp-call-tracking#7722
Merged
2 commits merged intomasterfrom Feb 24, 2017
unknown repository
Merged
Doc tweaks for formatting & style + valid layouts on amp-call-tracking#77222 commits merged intomasterfrom unknown repository
2 commits merged intomasterfrom
unknown repository
Conversation
alanorozco
requested changes
Feb 22, 2017
Member
alanorozco
left a comment
There was a problem hiding this comment.
Thanks! LGTM except for layout values.
| <tr> | ||
| <td class="col-fourty"><strong><a href="https://www.ampproject.org/docs/guides/responsive/control_layout.html">Supported Layouts</a></strong></td> | ||
| <td>fill, fixed, fixed-height, flex-item, responsive</td> | ||
| <td>container, fill, fixed, fixed-height, flex-item, nodisplay, responsive</td> |
Member
There was a problem hiding this comment.
Original set of values was correct.
Author
There was a problem hiding this comment.
Hmm, okay, but what does the validator for amp-call-tracking have more layouts?
supported_layouts: CONTAINER
supported_layouts: FILL
supported_layouts: FIXED
supported_layouts: FIXED_HEIGHT
supported_layouts: FLEX_ITEM
supported_layouts: NODISPLAY
supported_layouts: RESPONSIVE
Member
There was a problem hiding this comment.
The validator proto and the JS implementation are inconsistent. That was a mistake on my part. Created #7732 to fix it.
Member
There was a problem hiding this comment.
...and actually CONTAINER should be valid. Updated #7732 to reflect that.
In summary, the valid set is container, fill, fixed, fixed-height, flex-item, responsive.
Author
|
Removed |
alanorozco
approved these changes
Feb 24, 2017
mrjoro
pushed a commit
to mrjoro/amphtml
that referenced
this pull request
Apr 28, 2017
ampproject#7722) * Doc tweaks for formatting & style + valid layouts * Update amp-call-tracking.md
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviewed the doc for
amp-call-trackingand improved styling and wording to be consistent with other reference docs. Also, added "container" and "nodisplay" as acceptable layouts per what was specified in the validator-amp-call-tracking rules.to: @alanorozco
cc: @jasti
related to: #7493