Conversation
cramforce
approved these changes
Feb 3, 2017
|
|
||
| user().assert(opt_predefinedConfig || !from || !from['optout'], | ||
| user().assert(opt_predefinedConfig || !from || !from['optout'] || | ||
| from['optout'] == '_gaUserPrefs.ioo', |
Member
There was a problem hiding this comment.
Nit: indent at +4
Please document why this exception and that we are happy to add more such exceptions.
Contributor
Author
There was a problem hiding this comment.
done. Not sure if we'll need to do this again in future.
jridgewell
reviewed
Feb 3, 2017
| } | ||
|
|
||
| user().assert(opt_predefinedConfig || !from || !from['optout'], | ||
| user().assert(opt_predefinedConfig || !from || !from['optout'] || |
Contributor
There was a problem hiding this comment.
Please add a helping of comments for this unintuitive expression.
|
|
||
| user().assert(opt_predefinedConfig || !from || !from['optout'], | ||
| user().assert(opt_predefinedConfig || !from || !from['optout'] || | ||
| from['optout'] == '_gaUserPrefs.ioo', |
Contributor
There was a problem hiding this comment.
How does this function get injected into the page?
cramforce
approved these changes
Feb 3, 2017
erwinmombay
pushed a commit
that referenced
this pull request
Feb 3, 2017
* Update amp-analytics.js * review feedback. * Update amp-analytics.js
torch2424
pushed a commit
to torch2424/amphtml
that referenced
this pull request
Feb 14, 2017
* Update amp-analytics.js * review feedback. * Update amp-analytics.js
mrjoro
pushed a commit
to mrjoro/amphtml
that referenced
this pull request
Apr 28, 2017
* Update amp-analytics.js * review feedback. * Update amp-analytics.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added an additional condition to assert to confirm that if optout is used outside of predefined config, it is only what we expect it to be.