Skip to content

amp-selector: Clean up amp-selector experiment#7305

Merged
camelburrito merged 1 commit intoampproject:masterfrom
camelburrito:selector
Feb 2, 2017
Merged

amp-selector: Clean up amp-selector experiment#7305
camelburrito merged 1 commit intoampproject:masterfrom
camelburrito:selector

Conversation

@camelburrito
Copy link
Copy Markdown
Contributor

@camelburrito camelburrito commented Feb 2, 2017

Amp selector is launched 100% on prod, so cleaning up the experiment.

  • Removes experiment entry from experiments list
  • Removes the experiment from prod and canary JSON.
  • Removes experiment checks in the code base.
  • Remove usage of experiments in the unit test.
  • Updates manual test file

really help with making this more readable.

Fixes #6168

@camelburrito camelburrito merged commit 5e5173b into ampproject:master Feb 2, 2017
@ghost
Copy link
Copy Markdown

ghost commented Feb 9, 2017 •
edited by ghost
Loading

It looks like amp-selector is not yet deployed on production and that it is in fact still an experiment? Ex. https://ampbyexample.com/components/amp-selector/ fails without experiment/dev channel enabled.

@camelburrito
Copy link
Copy Markdown
Contributor Author

camelburrito commented Feb 9, 2017 •
edited
Loading

@erwinmombay - is this because we did a experiements release after my cleanup PR ? If so can we do one more experiments launch?

@camelburrito camelburrito deleted the selector branch February 9, 2017 18:44
@camelburrito camelburrito mentioned this pull request Feb 9, 2017
Merged
torch2424 pushed a commit to torch2424/amphtml that referenced this pull request Feb 14, 2017
@camelburrito @torch2424
Clean up amp-selector experiment (ampproject#7305)
f2d2a86
mrjoro pushed a commit to mrjoro/amphtml that referenced this pull request Apr 28, 2017
@camelburrito @mrjoro
Clean up amp-selector experiment (ampproject#7305)
346da97
alanorozco added a commit to alanorozco/amphtml that referenced this pull request Dec 4, 2020
@alanorozco
amp-playbuzz (ampproject#7403)
22c1271 
prod-config.json history:

eeebd93 - 2017-02-07T12:10:35-08:00
Launch make-body-relative (ampproject#7403)

5e5173b - 2017-02-02T12:48:07-08:00
Clean up  experiment (ampproject#7305)

f627a36 - 2017-01-10T14:14:28-08:00
Launch amp-selector (ampproject#6969)
alanorozco added a commit to alanorozco/amphtml that referenced this pull request Dec 4, 2020
@alanorozco
amp-playbuzz (ampproject#7403)
de53f27 
prod-config.json history:

 - eeebd93 - 2017-02-07T12:10:35-08:00
   Launch make-body-relative (ampproject#7403)

 - 5e5173b - 2017-02-02T12:48:07-08:00
   Clean up  experiment (ampproject#7305)

 - f627a36 - 2017-01-10T14:14:28-08:00
   Launch amp-selector (ampproject#6969)
alanorozco added a commit to alanorozco/amphtml that referenced this pull request Dec 5, 2020
@alanorozco
amp-playbuzz (ampproject#7403)
acba6e5 
prod-config.json history:

 - eeebd93 - 2017-02-07T12:10:35-08:00
   Launch make-body-relative (ampproject#7403)

 - 5e5173b - 2017-02-02T12:48:07-08:00
   Clean up $1amp-selector$1 experiment (ampproject#7305)

 - f627a36 - 2017-01-10T14:14:28-08:00
   Launch amp-selector (ampproject#6969)
alanorozco added a commit to alanorozco/amphtml that referenced this pull request Dec 5, 2020
@alanorozco
(2017-02-07, ampproject#7403) amp-playbuzz: 1
18f21b6 
prod-config.json history:

 - eeebd93 - 2017-02-07T12:10:35-08:00
   Launch make-body-relative (ampproject#7403)

 - 5e5173b - 2017-02-02T12:48:07-08:00
   Clean up `amp-selector` experiment (ampproject#7305)

 - f627a36 - 2017-01-10T14:14:28-08:00
   Launch amp-selector (ampproject#6969)
alanorozco added a commit to alanorozco/amphtml that referenced this pull request Dec 5, 2020
@alanorozco
(2017-02-07, ampproject#7403) amp-playbuzz: 1
ef6f093 
prod-config.json history:

 - eeebd93 - 2017-02-07T12:10:35-08:00
   Launch make-body-relative (ampproject#7403)

 - 5e5173b - 2017-02-02T12:48:07-08:00
   Clean up `amp-selector` experiment (ampproject#7305)

 - f627a36 - 2017-01-10T14:14:28-08:00
   Launch amp-selector (ampproject#6969)
alanorozco added a commit to alanorozco/amphtml that referenced this pull request Dec 5, 2020
@alanorozco
(2017-02-07, ampproject#7403) amp-playbuzz: 1
9554459 
prod-config.json history:

 - eeebd93 - 2017-02-07T12:10:35-08:00
   Launch make-body-relative (ampproject#7403)

 - 5e5173b - 2017-02-02T12:48:07-08:00
   Clean up `amp-selector` experiment (ampproject#7305)

 - f627a36 - 2017-01-10T14:14:28-08:00
   Launch amp-selector (ampproject#6969)
alanorozco added a commit to alanorozco/amphtml that referenced this pull request Dec 5, 2020
@alanorozco
(2017-02-07, ampproject#7403) amp-playbuzz: 1
08ea5cf 
prod-config.json history:

 - eeebd93 - 2017-02-07T12:10:35-08:00
   Launch make-body-relative (ampproject#7403)

 - 5e5173b - 2017-02-02T12:48:07-08:00
   Clean up `amp-selector` experiment (ampproject#7305)

 - f627a36 - 2017-01-10T14:14:28-08:00
   Launch amp-selector (ampproject#6969)
alanorozco added a commit to alanorozco/amphtml that referenced this pull request Dec 5, 2020
@alanorozco
(2017-02-07, ampproject#7403) amp-playbuzz: 1
8da63ca 
prod-config.json history:

 - eeebd93 - 2017-02-07T12:10:35-08:00
   Launch make-body-relative (ampproject#7403)

 - 5e5173b - 2017-02-02T12:48:07-08:00
   Clean up `amp-selector` experiment (ampproject#7305)

 - f627a36 - 2017-01-10T14:14:28-08:00
   Launch amp-selector (ampproject#6969)
alanorozco added a commit to alanorozco/amphtml that referenced this pull request Dec 5, 2020
@alanorozco
(2017-02-07, ampproject#7403) amp-playbuzz: 1
8ef2a29 
prod-config.json history:

 - eeebd93 - 2017-02-07T12:10:35-08:00
   Launch make-body-relative (ampproject#7403)

 - 5e5173b - 2017-02-02T12:48:07-08:00
   Clean up `amp-selector` experiment (ampproject#7305)

 - f627a36 - 2017-01-10T14:14:28-08:00
   Launch amp-selector (ampproject#6969)
alanorozco added a commit to alanorozco/amphtml that referenced this pull request Dec 5, 2020
@alanorozco
(2017-02-07, ampproject#7403) amp-playbuzz: 1
51b489e 
prod-config.json history:

 - eeebd93 - 2017-02-07T12:10:35-08:00
   Launch make-body-relative (ampproject#7403)

 - 5e5173b - 2017-02-02T12:48:07-08:00
   Clean up `amp-selector` experiment (ampproject#7305)

 - f627a36 - 2017-01-10T14:14:28-08:00
   Launch amp-selector (ampproject#6969)
github-actions bot pushed a commit to alanorozco/amphtml that referenced this pull request Dec 5, 2020
@alanorozco
(2017-02-07, ampproject#7403) amp-playbuzz: 1\n\nprod-config.json h…
2c73def 
…istory:\n\n - eeebd93 - 2017-02-07T12:10:35-08:00\n   Launch make-body-relative (ampproject#7403)\n\n - 5e5173b - 2017-02-02T12:48:07-08:00\n   Clean up `amp-selector` experiment (ampproject#7305)\n\n - f627a36 - 2017-01-10T14:14:28-08:00\n   Launch amp-selector (ampproject#6969)\n
github-actions bot pushed a commit to alanorozco/amphtml that referenced this pull request Dec 5, 2020
@alanorozco
(2017-02-07, ampproject#7403) amp-playbuzz: 1
f7e629a 
prod-config.json history:

 - eeebd93 - 2017-02-07T12:10:35-08:00
   Launch make-body-relative (ampproject#7403)

 - 5e5173b - 2017-02-02T12:48:07-08:00
   Clean up `amp-selector` experiment (ampproject#7305)

 - f627a36 - 2017-01-10T14:14:28-08:00
   Launch amp-selector (ampproject#6969)
github-actions bot pushed a commit to alanorozco/amphtml that referenced this pull request Dec 5, 2020
@alanorozco
(2017-02-07, ampproject#7403) amp-playbuzz: 1
5e4511e 
prod-config.json history:

 - eeebd93 - 2017-02-07T12:10:35-08:00
   Launch make-body-relative (ampproject#7403)

 - 5e5173b - 2017-02-02T12:48:07-08:00
   Clean up `amp-selector` experiment (ampproject#7305)

 - f627a36 - 2017-01-10T14:14:28-08:00
   Launch amp-selector (ampproject#6969)
github-actions bot pushed a commit to alanorozco/amphtml that referenced this pull request Dec 6, 2020
@alanorozco
(2017-02-07, eeebd93) amp-playbuzz: 1
f25c028 
Previous history on prod-config.json:

- eeebd93 - 2017-02-07T12:10:35-08:00 - Launch,make-body-relative,(ampproject#7403)

- 5e5173b - 2017-02-02T12:48:07-08:00 - Clean,up,`amp-selector`,experiment,(ampproject#7305)

- f627a36 - 2017-01-10T14:14:28-08:00 - Launch,amp-selector,(ampproject#6969)
github-actions bot pushed a commit to alanorozco/amphtml that referenced this pull request Dec 6, 2020
@alanorozco
(2017-02-07, eeebd93) amp-playbuzz: 1
233a3ec 
Previous history on prod-config.json:

- eeebd93 - 2017-02-07T12:10:35-08:00 - Launch,make-body-relative,(ampproject#7403)

- 5e5173b - 2017-02-02T12:48:07-08:00 - Clean,up,`amp-selector`,experiment,(ampproject#7305)

- f627a36 - 2017-01-10T14:14:28-08:00 - Launch,amp-selector,(ampproject#6969)
github-actions bot pushed a commit to alanorozco/amphtml that referenced this pull request Dec 7, 2020
@alanorozco
(2017-02-07, eeebd93) amp-playbuzz: 1
4c02ddb 
Previous history on prod-config.json:

- eeebd93 - 2017-02-07T12:10:35-08:00 - Launch,make-body-relative,(ampproject#7403)

- 5e5173b - 2017-02-02T12:48:07-08:00 - Clean,up,`amp-selector`,experiment,(ampproject#7305)

- f627a36 - 2017-01-10T14:14:28-08:00 - Launch,amp-selector,(ampproject#6969)
alanorozco added a commit to alanorozco/amphtml that referenced this pull request Dec 7, 2020
@alanorozco
(2017-02-07, eeebd93) amp-playbuzz: 1
75bcf66 
Previous history on prod-config.json:

- eeebd93 - 2017-02-07T12:10:35-08:00 - Launch make-body-relative (ampproject#7403)
- 5e5173b - 2017-02-02T12:48:07-08:00 - Clean up `amp-selector` experiment (ampproject#7305)
- f627a36 - 2017-01-10T14:14:28-08:00 - Launch amp-selector (ampproject#6969)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chenshay chenshay chenshay approved these changes

@erwinmombay erwinmombay Awaiting requested review from erwinmombay

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@camelburrito @chenshay