Fix computation of blacklisted_cdata_regex#7301
Merged
Gregable merged 1 commit intoampproject:masterfrom Feb 2, 2017
Gregable:validator-rollup
Merged
Fix computation of blacklisted_cdata_regex#7301Gregable merged 1 commit intoampproject:masterfrom Gregable:validator-rollup
Gregable merged 1 commit intoampproject:masterfrom
Gregable:validator-rollup
Conversation
…hiding the error in our tests.
honeybadgerdontcare
approved these changes
Feb 2, 2017
powdercloud
approved these changes
Feb 2, 2017
torch2424
pushed a commit
to torch2424/amphtml
that referenced
this pull request
Feb 14, 2017
…hiding the error in our tests. (ampproject#7301)
mrjoro
pushed a commit
to mrjoro/amphtml
that referenced
this pull request
Apr 28, 2017
…hiding the error in our tests. (ampproject#7301)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix computation of blacklisted_cdata_regex as well as code which was hiding the error in our tests.
This issue was being hidden by the fact that our test wasn't showing us the errors which this rule was supposed to catch (see incorrect_custom_style.out). This made me nervous that we had not been running these blacklist regexps at all.
As it turns out, we only ran them if the cdata section had no other errors. This was a holdover from a period when we had two ways to catch the same issue in cdata, so we skipped emitting the regexp issues if we had parser issues. That situation no longer is the case, so we can start emitting those errors again, which in turn is a slight code simplification.
The good news is that this has no effect on which docs are valid or invalid.
Addresses #7246