Skip to content

Add Swoop amp-ad support#7292

Merged
lannka merged 1 commit intoampproject:masterfrom
swoop-inc:mb_swoop_integration
Feb 1, 2017
Merged

Add Swoop amp-ad support#7292
lannka merged 1 commit intoampproject:masterfrom
swoop-inc:mb_swoop_integration

Conversation

@mbell697
Copy link
Copy Markdown
Contributor

@mbell697 mbell697 commented Feb 1, 2017

Implements support for Swoop via amp-ad.

  • Supports renderStart and noContentAvailable apis.
  • Uses computeInMasterFrame to load JS once per page
  • CLA has been signed, may be listed under mark@shopximity.com

Implements #7253

@jridgewell jridgewell requested a review from lannka February 1, 2017 20:52
@jridgewell
Copy link
Copy Markdown
Contributor

jridgewell commented Feb 1, 2017

/to @lannka

@lannka lannka self-assigned this Feb 1, 2017
@lannka lannka added the 3P label Feb 1, 2017
lannka
lannka approved these changes Feb 1, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@lannka lannka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job!

@lannka lannka merged commit 2a791b5 into ampproject:master Feb 1, 2017
torch2424 pushed a commit to torch2424/amphtml that referenced this pull request Feb 14, 2017
@mbell697 @torch2424
Add Swoop amp-ad support (ampproject#7292)
6f86217
mrjoro pushed a commit to mrjoro/amphtml that referenced this pull request Apr 28, 2017
@mbell697 @mrjoro
Add Swoop amp-ad support (ampproject#7292)
ad6b3ae
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@lannka lannka lannka approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@lannka lannka

Labels

WG: monetization

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mbell697 @jridgewell @lannka