Render associated element in error console#7277
Conversation
| element.tagName.toLowerCase() + | ||
| (element.id ? ' with id ' + element.id : '') + ':', | ||
| error.message); | ||
| output.call(console, error.message, element); |
There was a problem hiding this comment.
I'll explain my original thinking behind the old state. Lets discuss that, but I tend to agree that your PR makes things better:
I felt people might be confused that the DOM, especially when printed to the console looks different from their raw HTML -> Because we add all kinds of classes and attributes to it, add child elements, etc.
Having said that, this is probably better. Certainly in your case, where the elements aren't always an AmpElement and mutation from original source is expected.
Could you add a screenshot of the Chrome console to the PR description?
There was a problem hiding this comment.
Makes sense. Main reason for me is to make this API easier to use -- right now the only way to render the element is to set error.messageArray, which isn't done in error() or createError().
Before:
After:
For comparison, error generated by assert():
|
Thanks! |
assert()/to @cramforce /cc @jridgewell