Merged
Conversation
Contributor
|
i'll hold my piece. |
cramforce
approved these changes
Feb 1, 2017
| 'SL_Chrome_latest', | ||
| 'SL_Chrome_45', | ||
| 'SL_Firefox_latest', | ||
| 'SL_Safari_8', |
Member
There was a problem hiding this comment.
Lets comment out and document why.
This was referenced Feb 1, 2017
erwinmombay
approved these changes
Feb 1, 2017
torch2424
pushed a commit
to torch2424/amphtml
that referenced
this pull request
Feb 14, 2017
mrjoro
pushed a commit
to mrjoro/amphtml
that referenced
this pull request
Apr 28, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Safari 8 integration tests have been flaky for a few weeks now and I have spent more than a day trying to figure out what's happening without any luck. Given the small market share of Safari 8 (iOS < 9 is only 6% which also includes 7) and the value of keeping the build green to capture breakage in more important browsers. I am removing Safari 8 from SauceLabs.
If you object, speak now or forever hold your peace :)
/to @dvoytenko @cramforce @jridgewell @erwinmombay