Creates a pull request template for the project.#7193
Merged
cramforce merged 1 commit intoampproject:masterfrom Jan 25, 2017
Merged
Creates a pull request template for the project.#7193cramforce merged 1 commit intoampproject:masterfrom
cramforce merged 1 commit intoampproject:masterfrom
Conversation
The template should help make pull requests easier to read and overall more uniform. - Does not propose complicated syntax for titles (or rather forbids it). - Encourages referencing issues. This is a bit of an RFC. Feedback is welcome. One thing I don't actually know (and the GH docs don't say), is how this template influences auto-generated PR text. It would be really annoying if that no longer happened.
dvoytenko
approved these changes
Jan 25, 2017
erwinmombay
approved these changes
Jan 25, 2017
erwinmombay
reviewed
Jan 25, 2017
|
|
||
| Bullet points like | ||
|
|
||
| - Implements aspect X |
Member
There was a problem hiding this comment.
should it also be should it be imperative present tense like the PR header?
Member
Author
There was a problem hiding this comment.
Ha, really good question. I changed the title one for now. I don't find that particularly important.
jridgewell
pushed a commit
to jridgewell/amphtml
that referenced
this pull request
Jan 31, 2017
The template should help make pull requests easier to read and overall more uniform. - Does not propose complicated syntax for titles (or rather forbids it). - Encourages referencing issues. This is a bit of an RFC. Feedback is welcome. One thing I don't actually know (and the GH docs don't say), is how this template influences auto-generated PR text. It would be really annoying if that no longer happened.
mrjoro
pushed a commit
to mrjoro/amphtml
that referenced
this pull request
Apr 28, 2017
The template should help make pull requests easier to read and overall more uniform. - Does not propose complicated syntax for titles (or rather forbids it). - Encourages referencing issues. This is a bit of an RFC. Feedback is welcome. One thing I don't actually know (and the GH docs don't say), is how this template influences auto-generated PR text. It would be really annoying if that no longer happened.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The template should help make pull requests easier to read and overall more uniform.
This is a bit of an RFC. Feedback is welcome. One thing I don't actually know (and the GH docs don't say), is how this template influences auto-generated PR text. It would be really annoying if that no longer happened.