add a way to override hostname#6972
Conversation
gulpfile.js
Outdated
| var integrationJs = argv.fortesting | ||
| ? './f.js' | ||
| : `https://3p.ampproject.net/${internalRuntimeVersion}/f.js`; | ||
| : `https://${hostname3p}/${internalRuntimeVersion}/f.js`; |
There was a problem hiding this comment.
Doesn't f.js (3p/integration) already use urls defined config.js?
There was a problem hiding this comment.
i think this is actually the path thats embedded to remote.html, we'll need that updated too right?
There was a problem hiding this comment.
remote.html goes to the publisher. So for now we are just broken in those cases.
There was a problem hiding this comment.
ok i'll revert this line for now
|
I think that takes care of just about everything except for |
9e8cb3f to
6a9acf2
Compare
|
@cramforce PTAL |
gulpfile.js
Outdated
| var integrationJs = argv.fortesting | ||
| ? './f.js' | ||
| : `https://3p.ampproject.net/${internalRuntimeVersion}/f.js`; | ||
| : `https://3p.ampproject.org/${internalRuntimeVersion}/f.js`; |
* add a way to override hostname * rollback 3p url change * org -> net
* add a way to override hostname * rollback 3p url change * org -> net
ideally we would actually read this from a providers "config" and generate that config with the binary but theres some refactoring needed to do that. providing these flags for now to unblock #4293
Fixes #4293
/to @dknecht @jrf0110 for additional reviewers