Conversation
Contributor
|
Shall we make the change in amp-ad in the same PR for easier check-pick? |
Contributor
|
@muxin @erwinmombay can we cherry pick this PR to the current canary, so we can have it on production this week? /cc @harquail FYI this PR is going to fix your problem |
lannka
approved these changes
Jan 4, 2017
Member
|
Confirmed this fixes our bug. Thanks again! |
|
Thank you all for resolving this so quickly! Many thanks from all of us here at Yieldmo! |
muxin
pushed a commit
that referenced
this pull request
Jan 5, 2017
* Revert "Remove old IO file" * use old io * nit
jridgewell
pushed a commit
to jridgewell/amphtml
that referenced
this pull request
Jan 31, 2017
* Revert "Remove old IO file" * use old io * nit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #6362
Sadly we need to get this back before we have a solution to provide position info to 3p when its element is in viewport.
See discussion in #5603