Update form-vars-sub to use data-amp-replace and value attrs#6621
Merged
mkhatib merged 4 commits intoampproject:masterfrom Dec 14, 2016
Merged
Update form-vars-sub to use data-amp-replace and value attrs#6621mkhatib merged 4 commits intoampproject:masterfrom
mkhatib merged 4 commits intoampproject:masterfrom
Conversation
cramforce
requested changes
Dec 13, 2016
| * @param {!HTMLInputElement} element | ||
| * @return {string} Replaced string for testing | ||
| */ | ||
| expandInputValueSync(element) { |
Member
There was a problem hiding this comment.
Refactor to remove code duplication with Async function.
Contributor
Author
|
PTAL 👀 |
cramforce
approved these changes
Dec 14, 2016
jridgewell
reviewed
Dec 14, 2016
| } | ||
| const requestedReplacements = {}; | ||
| whitelist.trim().split(/\s+/).forEach(replacement => { | ||
| if (!opt_supportedReplacement || |
Contributor
Author
There was a problem hiding this comment.
That's true. this can be dropped. 👍
Lith
pushed a commit
to Lith/amphtml
that referenced
this pull request
Dec 22, 2016
Lith
pushed a commit
to Lith/amphtml
that referenced
this pull request
Dec 22, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A follow up to this discussion.
Let me know if this looks good, will update tests.