small fix to fake function prototype#6527
Merged
zhouyx merged 4 commits intoampproject:masterfrom Dec 7, 2016
Merged
Conversation
jridgewell
approved these changes
Dec 7, 2016
3p/integration.js
Outdated
| // Send request to received records. | ||
| if (window.IntersectionObserver && window.IntersectionObserver.prototype) { | ||
| if (window.IntersectionObserver && | ||
| Object.keys(window.IntersectionObserver.prototype).length) { |
Contributor
There was a problem hiding this comment.
We can check for IntersectionObserver.prototype.observe instead. Can we add a comment why the test is necessary, too?
jridgewell
reviewed
Dec 7, 2016
3p/integration.js
Outdated
| window.IntersectionObserver.prototype.observe) { | ||
| // use native IntersectionObserver if exist. NOTE: add the check for | ||
| // prototype.observer for test reason to force using polyfill by fake | ||
| // the prototype. |
Contributor
There was a problem hiding this comment.
Can you check the grammar?
Lith
pushed a commit
to Lith/amphtml
that referenced
this pull request
Dec 22, 2016
* small fix * remove comment * address comment * grammar
Lith
pushed a commit
to Lith/amphtml
that referenced
this pull request
Dec 22, 2016
* small fix * remove comment * address comment * grammar
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.