Reduce the number of recalc styles during a typically AMP boot procedure from 4 to 2#626
Merged
cramforce merged 1 commit intoampproject:masterfrom Oct 15, 2015
Merged
Conversation
src/viewport.js
Outdated
Contributor
There was a problem hiding this comment.
(this.scrollTop_ === null)?
Otherwise will keep requesting for 0.
d8aad15 to
783b4a4
Compare
Member
Author
|
PTAL |
src/viewport.js
Outdated
Contributor
There was a problem hiding this comment.
Here and below, {} style guide for if.
Member
There was a problem hiding this comment.
nvm, its already there [02:10:02] /home/travis/build/ampproject/amphtml/src/viewport.js: line 141, col 5, Error - Expected { after 'if' condition. (curly)
Member
Author
There was a problem hiding this comment.
Wow, I'm not usually this sloppy :)
783b4a4 to
d121bfd
Compare
Contributor
|
LGTM. Not sure what's in Travis. |
Member
|
@cramforce can you add a skip to that carousel test, will investigate and fix later. |
procedure from 4 to 2 which is likely the minimum possible right now. Refactors both viewport and resources to use the service pattern instead of being magic global singletons.
d121bfd to
593d6c4
Compare
cramforce
added a commit
that referenced
this pull request
Oct 15, 2015
Reduce the number of recalc styles during a typically AMP boot procedure from 4 to 2
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
which is likely the minimum possible right now.
Refactors both viewport and resources to use the service pattern
instead of being magic global singletons.