Added poster to amp-video docs; the implementation has been fixed a while back#622
Merged
dvoytenko merged 2 commits intoampproject:masterfrom Oct 14, 2015
Merged
Added poster to amp-video docs; the implementation has been fixed a while back#622dvoytenko merged 2 commits intoampproject:masterfrom
dvoytenko merged 2 commits intoampproject:masterfrom
Conversation
Member
|
maybe when we finish all the placeholder and progress work we can clarify the difference. LGTM |
|
are you going to amend https://github.com/ampproject/amphtml/blob/master/docs/include_features.md to use poster instead of the amp-img placeholder that doesn't work? |
Contributor
Author
|
@kevinmarks yes, updated. Placeholder now works as well. I expect we will clarify their use in a bit. |
dvoytenko
added a commit
that referenced
this pull request
Oct 14, 2015
Added poster to amp-video docs; the implementation has been fixed a while back
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #406.