Remove maximum-scale requirement for viewport#620
Merged
dvoytenko merged 3 commits intoampproject:masterfrom Oct 14, 2015
Merged
Remove maximum-scale requirement for viewport#620dvoytenko merged 3 commits intoampproject:masterfrom
dvoytenko merged 3 commits intoampproject:masterfrom
Conversation
…ble it when needed.
src/viewport.js
Outdated
Member
There was a problem hiding this comment.
could we add an explanation why we do this here.
src/viewport.js
Outdated
Member
There was a problem hiding this comment.
is it possible to just split on the = ? or is there anything unsafe in doing that (multiple =s ?)
let [name, value] = pair.split('=');
Contributor
Author
There was a problem hiding this comment.
Yeah, it's nice. I'll redo. Things get a little less "pretty" once you start doing trims, etc.
Member
There was a problem hiding this comment.
true, i'm ok with this implementation 👍
Member
|
@dvoytenko LGTM! |
dvoytenko
added a commit
that referenced
this pull request
Oct 14, 2015
Remove maximum-scale requirement for viewport
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and add ability to disable it when needed.
Closes #592.
/cc @cramforce