Adds some comments and refactors some of the presubmit-check for clarity#616
Merged
erwinmombay merged 5 commits intoampproject:masterfrom Oct 14, 2015
Merged
Conversation
Some of the functions had missing or incorrect comments so this change adds some more comments for consistency and makes a change to use a vinyl file where it was specified in the comments but not used yet in the code. Also, I renamed one of the functions to better reflect what was being tested (any vs all) as it didn't make sense based on the current logic.
Member
There was a problem hiding this comment.
oh can you change this to @return {boolean}
Contributor
Author
|
Bah! I need a line length checker setup in my vimrc... |
Member
|
@jaboc83 something like set colorcolumn=80
highlight ColorColumn guibg=Gray14should work (if you just wanted a ruler) |
Contributor
Author
|
Ha, yeah, I just added the exact same thing |
Member
There was a problem hiding this comment.
sentence feels incomplete, maybe remove with ?
Member
|
LGTM! thanks |
erwinmombay
added a commit
that referenced
this pull request
Oct 14, 2015
Adds some comments and refactors some of the presubmit-check for clarity
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of the functions had missing or incorrect comments so this change adds
some more comments for consistency and makes a change to use a vinyl file
where it was specified in the comments but not used yet in the code. Also,
I renamed one of the functions to better reflect what was being tested (any vs all)
as it didn't make sense based on the current logic.