Force transfer sidebar to the Fixed 'transfer' layer.#6155
Merged
camelburrito merged 8 commits intoampproject:masterfrom Nov 22, 2016
Merged
Force transfer sidebar to the Fixed 'transfer' layer.#6155camelburrito merged 8 commits intoampproject:masterfrom
camelburrito merged 8 commits intoampproject:masterfrom
Conversation
dvoytenko
approved these changes
Nov 11, 2016
| this.vsync_.mutate(() => { | ||
| toggle(this.element, /* display */true); | ||
| this.viewport_.addToFixedLayer(this.element); | ||
| this.viewport_.addToFixedLayer(this.element, /*forceTransfer*/ true); |
Contributor
There was a problem hiding this comment.
nit: spaces inside the /**/
Contributor
Author
|
@dvoytenko - this is not performing too well with animations - ill have to re-think this. |
Contributor
|
@camelburrito This probably simple means that we'll have to split |
Contributor
Author
|
i tried that already , the animation is stuttering and not looking very good. |
Contributor
|
@camelburrito If animation is stuttering, that simply means that we need to separate layout changes with animation run. 1 or 2 animation frames would do it. |
798e358 to
1122b49
Compare
Contributor
Author
|
@dvoytenko could you take another look. I made a minor change in fixed-layer |
1122b49 to
ce9da15
Compare
dvoytenko
reviewed
Nov 22, 2016
src/service/fixed-layer.js
Outdated
| // transfering of more substantial sections for now. Likely to be | ||
| // relaxed in the future. | ||
| const isTransferrable = ( | ||
| const isTransferrable = fe.forceTransfer || ( |
Contributor
There was a problem hiding this comment.
Since you added forceTransfer already in isFixed, you should defer to isFixed here. E.g. it should likely look like:
const isTransferrable = isFixed && (
fe.forceTransfer || (opacity > 0 && ...)
);
dvoytenko
approved these changes
Nov 22, 2016
ce9da15 to
c7c36be
Compare
Lith
pushed a commit
to Lith/amphtml
that referenced
this pull request
Dec 22, 2016
* Force transfer sidebar to the Fixed 'transfer' layer. * review fix. * Move to fixed layer before opening. * Adding to fixed layer before dp block * moving fl to build cb * Make isFixed true for forceTransferElements * Make isFixed true for forceTransferElements * Review fixes
Lith
pushed a commit
to Lith/amphtml
that referenced
this pull request
Dec 22, 2016
* Force transfer sidebar to the Fixed 'transfer' layer. * review fix. * Move to fixed layer before opening. * Adding to fixed layer before dp block * moving fl to build cb * Make isFixed true for forceTransferElements * Make isFixed true for forceTransferElements * Review fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes - #6045