Fixes regex typo for dedicatedCopyrightNoteSources#614
Merged
cramforce merged 1 commit intoampproject:masterfrom Oct 14, 2015
Merged
Fixes regex typo for dedicatedCopyrightNoteSources#614cramforce merged 1 commit intoampproject:masterfrom
cramforce merged 1 commit intoampproject:masterfrom
Conversation
The previous regex was not looking for '.' specifically prior to the css file extension which could cause it to accidentally match scss as well as .css. I changed it to match same way javascript extensions are being matched.
Member
|
Thanks. LGTM |
cramforce
added a commit
that referenced
this pull request
Oct 14, 2015
Fixes regex typo for dedicatedCopyrightNoteSources
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous regex was not looking for '.' specifically prior to the
css file extension which could cause it to accidentally match scss
as well as .css. I changed it to match same way javascript extensions
are being matched.