Skip to content

A unified placeholder and fallback system for layout.#602

Merged
dvoytenko merged 1 commit intoampproject:masterfrom
dvoytenko:placeholder2
Oct 14, 2015
Merged

A unified placeholder and fallback system for layout.#602
dvoytenko merged 1 commit intoampproject:masterfrom
dvoytenko:placeholder2

Conversation

@dvoytenko
Copy link
Copy Markdown
Contributor

@dvoytenko dvoytenko commented Oct 13, 2015

/cc @erwinmombay

Closes #406.

Notable changes:

  1. Placeholder/fallback code is refactored from BaseElement to AmpElement to allow earlier workflows to take place before BaseElement is upgraded.
  2. Placeholder is consistently now toggled off once the first layout is complete. Overrideable by subclasses (e.g. amp-anim).
  3. A new spec file created specifically for layout and all its attributes.

erwinmombay
erwinmombay reviewed Oct 13, 2015
View reviewed changes
spec/amp-html-layout.md Outdated
Copy link
Copy Markdown
Member

@erwinmombay erwinmombay Oct 13, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reosurces -> resources

Copy link
Copy Markdown
Contributor Author

@dvoytenko dvoytenko Oct 13, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you running jaro-winkler in your head? :) Done.

Copy link
Copy Markdown
Member

@erwinmombay erwinmombay Oct 13, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i have a plugin 😉

@erwinmombay
Copy link
Copy Markdown
Member

erwinmombay commented Oct 14, 2015

@dvoytenko can you rebase? I'll LGTM right after

@dvoytenko
Copy link
Copy Markdown
Contributor Author

dvoytenko commented Oct 14, 2015

@erwinmombay rebased. PTAL.

@erwinmombay
Copy link
Copy Markdown
Member

erwinmombay commented Oct 14, 2015

LGTM.

dvoytenko added a commit that referenced this pull request Oct 14, 2015
@dvoytenko
Merge pull request #602 from dvoytenko/placeholder2
0d3eb98 
A unified placeholder and fallback system for layout.
@dvoytenko dvoytenko merged commit 0d3eb98 into ampproject:master Oct 14, 2015
@dvoytenko dvoytenko deleted the placeholder2 branch October 14, 2015 18:30
@elijahsoria elijahsoria mentioned this pull request Aug 15, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@cramforce cramforce

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dvoytenko @erwinmombay @AaronCritchley @cramforce