Skip to content

Prune unused deps 2#509

Merged
erwinmombay merged 3 commits intoampproject:masterfrom
psyrendust:prune-unused-deps-2
Oct 7, 2015
Merged

Prune unused deps 2#509
erwinmombay merged 3 commits intoampproject:masterfrom
psyrendust:prune-unused-deps-2

Conversation

@psyrendust
Copy link
Copy Markdown
Contributor

@psyrendust psyrendust commented Oct 7, 2015

Submitting again to force travis-ci to re-run.

Changes

  • [6e9357a] chore(package): prune deps that are no longer used in package.json
  • [09542af] chore(gulpfile): remove unused var argv in gulpfile
  • [51196c3] fix(gulpfile): remove duplicate var declaration for fs in gulpfile

@psyrendust psyrendust mentioned this pull request Oct 7, 2015
Closed
@psyrendust
Copy link
Copy Markdown
Contributor Author

psyrendust commented Oct 7, 2015

@erwinmombay resubmitted

@psyrendust
Copy link
Copy Markdown
Contributor Author

psyrendust commented Oct 7, 2015

It's going to fail. I know what the error is. npm install is failing. I ran into this issue awhile back with node @4.0.0, which is what travis is setup to use. I'll bump this to node @4.1.2 and run the build again.

@psyrendust
Copy link
Copy Markdown
Contributor Author

psyrendust commented Oct 7, 2015

@erwinmombay Hm, well this seemed to have passed. But there is an issue with npm install tossing errors (I counted about 4 of them) like the following:

gyp ERR! build error 
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/home/travis/.nvm/versions/node/v4.0.0/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:270:23)
gyp ERR! stack     at emitTwo (events.js:87:13)
gyp ERR! stack     at ChildProcess.emit (events.js:172:7)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:200:12)
gyp ERR! System Linux 3.13.0-40-generic
gyp ERR! command "/home/travis/.nvm/versions/node/v4.0.0/bin/node" "/home/travis/.nvm/versions/node/v4.0.0/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /home/travis/build/ampproject/amphtml/node_modules/karma/node_modules/socket.io/node_modules/socket.io-client/node_modules/engine.io-client/node_modules/ws/node_modules/utf-8-validate
gyp ERR! node -v v4.0.0
gyp ERR! node-gyp -v v3.0.1
gyp ERR! not ok

If you are cool with this PR, then I'll submit another one that bumps the version of node to @4.1 to see if that takes care of the npm install errors.

@erwinmombay
Copy link
Copy Markdown
Member

erwinmombay commented Oct 7, 2015

@psyrendust LGTM.

the errors already exist on master so this PR isnt a cause of it for sure. 👍 thanks again for cleaning up our gulpfile!

erwinmombay added a commit that referenced this pull request Oct 7, 2015
@erwinmombay
Merge pull request #509 from psyrendust/prune-unused-deps-2
6839a90 
Prune unused deps 2
@erwinmombay erwinmombay merged commit 6839a90 into ampproject:master Oct 7, 2015
@sohanirao sohanirao mentioned this pull request Feb 13, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@psyrendust @erwinmombay