Added ability to specify tag names in selectors#4633
Merged
avimehta merged 5 commits intoampproject:masterfrom Aug 24, 2016
Merged
Added ability to specify tag names in selectors#4633avimehta merged 5 commits intoampproject:masterfrom
avimehta merged 5 commits intoampproject:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Change the message please.
Contributor
|
LGTM with few comments. |
* Added ability to specify tag names in selectors. If a tag name is specified, an ancestor of the amp-analytics tag with idetified by the tag name will be used for visibilitySpec. Fixes ampproject#4018
Contributor
Author
|
ptal. I had to make substantial changes to test to accommodate for using |
Contributor
Author
|
@dvoytenko I have been seeing these tests fail on some of the runs. ANy idea why this is happening? The tests pass if I rerun them. https://travis-ci.org/ampproject/amphtml/builds/154618433 |
Contributor
|
@avimehta Test failures appear to be unrelated. But please ping Erwin if you keep seeing them. |
Contributor
|
LGTM |
ariangibson
pushed a commit
to Mixpo/amphtml
that referenced
this pull request
Sep 7, 2016
* Added ability to specify tag names in selectors. (ampproject#4368) * Added ability to specify tag names in selectors. If a tag name is specified, an ancestor of the amp-analytics tag with idetified by the tag name will be used for visibilitySpec. Fixes ampproject#4018
mityaha
pushed a commit
to brightcove-archive/ooyala_amphtml
that referenced
this pull request
Nov 30, 2016
* Added ability to specify tag names in selectors. (ampproject#4368) * Added ability to specify tag names in selectors. If a tag name is specified, an ancestor of the amp-analytics tag with idetified by the tag name will be used for visibilitySpec. Fixes ampproject#4018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Roll forward #4617 with bug fixes and tests.
First commit is same as #4368
Second commit includes all the bugfixes.
Third commit adds the tests.
/to @dvoytenko