Make scrollable-carousel functional#4331
Merged
muxin merged 2 commits intoampproject:masterfrom Aug 4, 2016
Merged
Conversation
Contributor
muxin
commented
Aug 2, 2016
- Make carousel container overflow-x: auto
- Use scroll event listener
- Use scrollLeft as the current position
- Update resource loading when scrolling is slow
- Remove the touch event listeners
Contributor
Author
db118ac to
ad2a33e
Compare
ad2a33e to
510faa1
Compare
510faa1 to
47c655e
Compare
47c655e to
2e21299
Compare
Contributor
|
LGTM |
ariangibson
pushed a commit
to Mixpo/amphtml
that referenced
this pull request
Sep 7, 2016
mityaha
pushed a commit
to brightcove-archive/ooyala_amphtml
that referenced
this pull request
Nov 30, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.