Merged
Conversation
…-size messages. Added a test using a nested frame to verify that these messages are received correctly.
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
This was referenced Jul 14, 2016
| if (newHeight !== undefined || newWidth !== undefined) { | ||
| this.updateSize_(newHeight, newWidth, source, origin); | ||
| } | ||
| }, this.is3p_, this.is3p_)); |
Contributor
There was a problem hiding this comment.
is it intended to use is3p_ for opt_includingNestedWindows?
Contributor
Author
There was a problem hiding this comment.
Yes it is. The option was created with 3P use cases in mind. TBH, I'm not sure amp-ad ever has this set to false, but I'm keeping things consistent.
|
CLAs look good, thanks! |
Contributor
|
LGTM |
Contributor
Author
|
Resolved conflicts. |
| if (this.pendingResizeRequest_) { | ||
| // There is an already pending resize request, fail it. | ||
| this.sendEmbedSizeResponse_(false /* success */); | ||
| } |
Contributor
camelburrito
added a commit
to camelburrito/amphtml
that referenced
this pull request
Jul 25, 2016
This reverts commit 6bccb65.
camelburrito
pushed a commit
that referenced
this pull request
Jul 25, 2016
ariangibson
pushed a commit
to Mixpo/amphtml
that referenced
this pull request
Sep 7, 2016
* Changed <amp-ad> to allow nested frames to request resize using embed-size messages. Added a test using a nested frame to verify that these messages are received correctly.
ariangibson
pushed a commit
to Mixpo/amphtml
that referenced
this pull request
Sep 7, 2016
This reverts commit 6bccb65.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modifies to allow nested frames to request resize using embed-size messages. Adds a test that verifies messages from nested frames are handled correctly, also tested manually.
This is the another change in the implementation of #3019.