Refactoring: Turn private custom element methods into functions.#3882
Merged
cramforce merged 2 commits intoampproject:masterfrom Jul 2, 2016
Merged
Refactoring: Turn private custom element methods into functions.#3882cramforce merged 2 commits intoampproject:masterfrom
cramforce merged 2 commits intoampproject:masterfrom
Conversation
src/custom-element.js
Outdated
Member
There was a problem hiding this comment.
just for my own knowledge, is it right that this function inherits the same signatures as the method?
Member
|
LGTM, 1 question and 1 nit. |
src/custom-element.js
Outdated
Contributor
There was a problem hiding this comment.
This wouldn't be called when there's an error in the previous code.
And inline a few methods. The calls on the element are slow and cannot be optimized because the compiler doesn't touch the extern objects.
0027e4f to
1ce6f02
Compare
Member
Author
|
Addressed review comments |
jonasmattsson1
added a commit
to widespace-os/amphtml
that referenced
this pull request
Jul 5, 2016
* master: (236 commits) trim all the columns (ampproject#3894) Refactoring: Turn private custom element methods into functions. (ampproject#3882) Lower the load priority of ad shaped iframes. (ampproject#3863) JsDoc fix (ampproject#3892) Add screenshots for Opera to AMP Validator extension. (ampproject#3866) Fix renaming of generated JSCompiler_prototypeAlias variable. (ampproject#3887) fix typo in amp-sidebar.md (ampproject#3833) Validator Roll-up (ampproject#3885) [CryptoService] Leverage browser native Crypto API to hash strings. (ampproject#3850) Size update (ampproject#3883) copy amp-ad docs to builtins (ampproject#3879) move doc to extension (ampproject#3878) [amp-experiment] Exposes isDismissed() method in AmpUserNotification (ampproject#3832) fix action-impl warning on dist (ampproject#3867) Add params for microad (ampproject#3827) Fixed some A4A tests. (ampproject#3859) Updates to colanalytics vendor config for amp-analytics. (ampproject#3849) Changes to implement A4A (AMP ads for AMP pages) (ampproject#3534) Addresses comment left over from PR#3841 (ampproject#3853) Expose submit event with on=submit:el.action syntax. (ampproject#3739) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And inline a few methods.
The calls on the element are slow and cannot be optimized because the compiler doesn't touch the extern objects.