Skip to content

Install npm packages with --legacy-peer-deps on ci#38266

Merged
estherkim merged 4 commits intoampproject:mainfrom
estherkim:node16
Jun 6, 2022
Merged

Install npm packages with --legacy-peer-deps on ci#38266
estherkim merged 4 commits intoampproject:mainfrom
estherkim:node16

Conversation

@estherkim
Copy link
Copy Markdown
Collaborator

@estherkim estherkim commented Jun 6, 2022

Super temp workaround to avoid running npm ci on circleci that fails...

Also pin protobuf to v3.19.4 until amp validator can be fixed with new version

validator-tests.js Running amp validator...
[17:10:01] Using task file project/amp.js
[17:10:01] Starting 'validator'...
Traceback (most recent call last):
  File "build.py", line 620, in <module>
    Main(parser.parse_args())
  File "build.py", line 597, in Main
    GenValidatorProtoGeneratedJs(out_dir='dist')
  File "build.py", line 195, in GenValidatorProtoGeneratedJs
    from dist import validator_pb2
  File "/home/circleci/project/validator/dist/validator_pb2.py", line 33, in <module>
    _descriptor.EnumValueDescriptor(
  File "/home/circleci/.local/lib/python3.8/site-packages/google/protobuf/descriptor.py", line 755, in __new__
    _message.Message._CheckCalledFromGeneratedFile()
TypeError: Descriptors cannot not be created directly.
If this call came from a _pb2.py file, your generated code is out of date and must be regenerated with protoc >= 3.19.0.
If you cannot immediately regenerate your protos, some other possible workarounds are:
 1. Downgrade the protobuf package to 3.20.x or lower.
 2. Set PROTOCOL_BUFFERS_PYTHON_IMPLEMENTATION=python (but this will use pure-Python parsing and will be much slower).

@estherkim estherkim changed the title [wip] Keep node v16.15.0 on circleci Keep node v16.15.0 on circleci Jun 6, 2022
@estherkim estherkim requested a review from danielrozenberg June 6, 2022 15:36
@estherkim estherkim changed the title Keep node v16.15.0 on circleci Install npm packages with --legacy-peer-deps on ci Jun 6, 2022
@estherkim estherkim merged commit d0a2b8c into ampproject:main Jun 6, 2022
ampprojectbot pushed a commit that referenced this pull request Jun 10, 2022
* use 16.15.0

* legacy peer deps

* lts

* protobuf

(cherry picked from commit d0a2b8c)
ampprojectbot pushed a commit that referenced this pull request Jun 10, 2022
* use 16.15.0

* legacy peer deps

* lts

* protobuf

(cherry picked from commit d0a2b8c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants