Install npm packages with --legacy-peer-deps on ci#38266
Merged
estherkim merged 4 commits intoampproject:mainfrom Jun 6, 2022
Merged
Install npm packages with --legacy-peer-deps on ci#38266estherkim merged 4 commits intoampproject:mainfrom
--legacy-peer-deps on ci#38266estherkim merged 4 commits intoampproject:mainfrom
Conversation
danielrozenberg
approved these changes
Jun 6, 2022
--legacy-peer-deps on ci
ampprojectbot
pushed a commit
that referenced
this pull request
Jun 10, 2022
* use 16.15.0 * legacy peer deps * lts * protobuf (cherry picked from commit d0a2b8c)
ampprojectbot
pushed a commit
that referenced
this pull request
Jun 10, 2022
* use 16.15.0 * legacy peer deps * lts * protobuf (cherry picked from commit d0a2b8c)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Super temp workaround to avoid running
npm cion circleci that fails...Also pin protobuf to v3.19.4 until
amp validatorcan be fixed with new version