🚀 [Story performance] Remove interactive host styles#37472
Merged
mszylkowski merged 12 commits intoampproject:mainfrom Jan 25, 2022
Merged
🚀 [Story performance] Remove interactive host styles#37472mszylkowski merged 12 commits intoampproject:mainfrom
mszylkowski merged 12 commits intoampproject:mainfrom
Conversation
|
Hey @gmajoulet! These files were changed: Hey @newmuis! These files were changed: |
gmajoulet
approved these changes
Jan 25, 2022
rileyajones
pushed a commit
to rileyajones/amphtml
that referenced
this pull request
Jan 26, 2022
* Added tasts * Undo * Moved interactive components CSS into extension * Updated zindex * Fix linting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The host styles for interactive components can be moved to the interactive components extension to reduce the bundle size for the amp-story bundle.
Replaces #37051 but doesn't store any of the styles on
amp-story.cssbecause the layout shifts that could happen due to the interactive components won't be fixed by keeping the layout styles there, as the height is independent of any of these styles, and is the main contributor to any CLS that could potentially happen. In reality, the chance that the interactive components are downloaded before amp-story is very high.