✨ amp-story-shopping-tag text specs#37186
Merged
jshamble merged 31 commits intoampproject:mainfrom Jan 19, 2022
Merged
Conversation
|
Hey @gmajoulet! These files were changed: |
Contributor
coreymasanto
left a comment
There was a problem hiding this comment.
Please add images to the description that show how the single line, 2-line, and 2-line overflow cases appear on your local AMP server
gmajoulet
reviewed
Dec 13, 2021
…e demonstration language.
gmajoulet
reviewed
Dec 16, 2021
Contributor
|
To recap our GVC:
Please look into if there is a way to remove the extra space when there are line breaks: |
coreymasanto
approved these changes
Jan 19, 2022
processprocess
approved these changes
Jan 19, 2022
Contributor
processprocess
left a comment
There was a problem hiding this comment.
Looks great to me!
gmajoulet
reviewed
Jan 19, 2022
Contributor
|
I just added several comments, can you address them in a follow up PR please? They're important accessibility and performance things. |
mhalabi-google
pushed a commit
to mhalabi-google/amphtml
that referenced
this pull request
Jan 20, 2022
* added some shopping tag text specs * added shopping tag text specs * fixed shopping tag * fixed shopping tag * added visual diff test * fixed nit, one liner comment * added dynamic border radius for styling with two tag texts * added better name * added correct calls for clientrect for using measuremutate eleemnt * updated spec exampel to have tags with rtl support, used arabic as the demonstration language. * fixed a few issues with shopping tag specs * resolved mrege conflicts iwth main * removed duplicate page id * fixed blank page on no products * added suggestion about ?. null operator * added text specs * added parseInt to font size to fix border radius * fixed all issues except for multi-line ellipsis * added shopping tag text specs ellipsis fix (it had to do with flex display) * rmeoved gitignore file * added mutate element * added more relvant example * updated visual diff tests * added classlist optimization for mutatelement * type * fix circleCI tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added tech specs for the shopping tag, handle single line, 2-line, and 2-line overflow (ellipsis) cases.
Fixes #37039