✨ Render page level CTA when amp-story-shopping-attachment exists#36721
Merged
processprocess merged 11 commits intoampproject:mainfrom Nov 3, 2021
Merged
✨ Render page level CTA when amp-story-shopping-attachment exists#36721processprocess merged 11 commits intoampproject:mainfrom
processprocess merged 11 commits intoampproject:mainfrom
Conversation
|
Hey @gmajoulet, @newmuis! These files were changed: |
coreymasanto
requested changes
Nov 2, 2021
coreymasanto
approved these changes
Nov 3, 2021
rileyajones
pushed a commit
to rileyajones/amphtml
that referenced
this pull request
Nov 4, 2021
…pproject#36721) * Add shopping attachment to list of attachment elements with CTA UI. * Add visual test * Remove whitespace * Use amp-story-draggable-drawer-root * Add dark theme page to example. * Update ID * use shopping attachment. * remove empty space * Update diff path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
amp-story-shopping-attachmentto list of elements that need a CTA button rendered.Adds visual test for default and dark theme.
Adds example for dark theme.
Fixes #36697