๐(amp-lightbox-gallery): opens to selected image, resolve #35920#36103
Conversation
3324dec to
efae695
Compare
kristoferbaxter
left a comment
There was a problem hiding this comment.
Left two comments, not enough context to approve.
extensions/amp-lightbox-gallery/0.1/test/test-amp-lightbox-gallery.js
Outdated
Show resolved
Hide resolved
efae695 to
b4dc5f9
Compare
|
Hey @gmajoulet, @newmuis! These files were changed: Hey @ampproject/wg-caching! These files were changed: |
|
This pull request introduces 1 alert when merging a5db5d0 into 6cbef53 - view on LGTM.com new alerts:
|
โฆ5920 removed a unlayout call that would cause the image to default to the first slide
a5db5d0 to
2ca143a
Compare
| if (enter) { | ||
| Services.ownersForDoc(this.element)./*OK*/ scheduleUnlayout( | ||
| this.element, | ||
| this.carousel_ | ||
| ); | ||
| } | ||
|
|
There was a problem hiding this comment.
I'm not sure that this is desirable. For example, this could cause a video to remain playing. Could you manually test a few cases using amp-video and amp-youtube? Happy to approve once we verify this.
There was a problem hiding this comment.
Alan and I are having trouble figuring out what this feature is meant to be supported.
When I added the amp-youtube component, it doesn't appear to trigger the lightbox gallery.
There was a problem hiding this comment.
Looks like this removed section was introduced in #34630, maybe @kristoferbaxter can provide some context?
* tickevents: remove unused enum values (ampproject#36159) * tickevents: remove unused enum values * Remove dupe of CLS, fidv, lj1,lj2 * format * ๐ฆ Update cimg/openjdk Docker tag to v17 (ampproject#36172) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * ๐ฆ Update dependency rollup to v2.57.0 (ampproject#36134) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * ๐ฆ Update dependency @octokit/graphql to v4.7.0 (ampproject#35844) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * โป๏ธ Migrate `observeWithSharedInOb` to `observeIntersections` (ampproject#36106) * ๐ Make setup-node step consistent across gh actions (ampproject#36175) * Partially revert "๐ Parallelize `dist` steps (ampproject#35943)" (ampproject#36176) * Revert "๐ Parallelize `dist` steps (ampproject#35943)" This reverts commit 1e2c808. * Partially allow parallelization for smaller tasks * Also include `compileAllJs` in the parallelized part * (amp-lightbox-gallery): opens to selected image, resolve ampproject#35920 (ampproject#36103) removed a unlayout call that would cause the image to default to the first slide * โป๏ธ preact inob: small cleanup (ampproject#36177) * preact inob: small cleanup * also remove current * build-system: only write version.txt once per dir (ampproject#36162) * build-system: only write version.txt once * output full set of * sort the paths * write files...not directories * succinct format * bind-impl: missing ampStateEl is a user error (ampproject#36113) * Update Yandex & ADFOX amp-ad codes (ampproject#35442) * ๐งชUpdate OT token for attribution-reporting (ampproject#36181) * ๐ Add `exports` for stylesheets to `package.json` (ampproject#36027) * Add styles.css export to package.json * Conditionally add export * Use `fast-glob` * Add separate export entry for each stylesheet * window support * sort for lint Co-authored-by: Jake Fried <samouri@users.noreply.github.com> * โจ [bento][amp-iframe] Add validator rules for 1.0 (ampproject#36182) * ๐ฎ Sweep experiments older than 2021-02-01 (ampproject#35486) Sweep experiments last flipped globally up to 2021-02-01: - (2021-01-20, a9e2778) `adsense-ad-size-optimization`: 1 * UTF8 encoding/decoding library to deprecated utf8 functions in strings.h|cc (ampproject#36184) library. PiperOrigin-RevId: 398102411 Co-authored-by: Amaltas Bohra <amaltas@google.com> * Validator rollup (ampproject#36185) * cl/398081751 Use the proto message number instead of index for enums. * cl/398323481 Two-way sync for PR ampproject#36085. No-op, or fixes merge conflicts, if any. Co-authored-by: honeybadgerdontcare <sedano@google.com> * ๐ฆ Update dependency @octokit/rest to v18.11.2 (ampproject#36180) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * deps: bump bento-compiler (ampproject#36191) * ๐ฆ Update dependency @jest/core to v27.2.3 (ampproject#36189) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * ๐ฆ Update dependency esbuild to v0.12.25 (ampproject#35928) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * ๐ฆ Update linting devDependencies (ampproject#36119) * ๐ฆ Update linting devDependencies * Fix lint errors Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> Co-authored-by: Raghu Simha <rsimha@amp.dev> * ๐ฆ Update dependency axios to 0.21.2 [SECURITY] (ampproject#35999) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * ๐ฆ Update dependency esbuild to v0.13.3 (ampproject#36198) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * ๐ฆ Update dependency tar to v6.1.9 [SECURITY] (ampproject#35509) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * performance-impl: cant check ampdoc vis hidden while null (ampproject#36197) * performance-impl: cant check ampdoc vis hidden before initted * Add unit test * ๐ Add nice colors to release tagger logs (ampproject#36200) * log * comment * ๐ฆ Update core devDependencies (ampproject#36196) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * ๐ฆ Update dependency @ampproject/worker-dom to v0.32.0 (ampproject#36138) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * ๐ฆ Update dependency google-closure-library to v20210808 (ampproject#35617) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * SwG Release 0.1.22.186 (ampproject#36202) * ๐ฆ Update dependency chromedriver to v94 (ampproject#35951) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> Co-authored-by: Raghu Simha <rsimha@amp.dev> * ๐ฆ Update dependency tar to v6.1.11 (ampproject#36203) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * ๐ `bento-facebook` Documentation (ampproject#36038) * [`bento-facebook`] Update the amp-facebook.md file for both 0.1 and 1.0. Add a README.md for 1.0 bento mode. * [`bento-facebook`] Add documentation to describe the amp-facebook usage outside of valid AMP docs. * [`bento-facebook`] Add readme.md for BentoFacebook. * [`bento-facebook`] Address PR comments to update some attribute names. * [`bento-facebook`] Update CDN link to bento-facebook-1.0.js. * [`bento-facebook`] Prettify amp-facebook.md. * [`bento-facebook`] Update dead link to FB documentation to a real link. * [`bento-facebook`] Update dead links to be valid. * ๐ฎ Clean up dead amp-sidebar code within stories (ampproject#36178) * Remove amp-sidebar code from extensions/amp-story * Remove amp-sidebar visual tests from examples/visual-tests/amp-story * Remove reference to amp-sidebar from amp-story-interactive README * Remove remaining amp-sidebar logic from extensions/amp-story * Remove amp-sidebar logic from amp-story-system-layer code * Remove amp-sidebar code from amp-story-store-service.js * Remove amp-sidebar storybook JS files * A few missed deletions in test-amp-story and build-system/ caught by linter * Revert extensions/amp-sidebar/*/storybook removal from forbidden terms * Add back the amp-sidebar storybook files * Add newline at end of each storybook file * Run amp get-zindex --fix * ๐ [amp-story-panning-media] Set width on amp-img el (ampproject#36217) * Set width on amp-img el. * Add height * ๐ฆ Update dependency @octokit/rest to v18.11.3 (ampproject#36212) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * ๐ฆ Update dependency eslint-plugin-react to v7.26.1 (ampproject#36214) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * ๐ฆ Update dependency @ampproject/bento-compiler to v0.0.9 (ampproject#36225) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * โป๏ธDon't fetch crypto signature verifier in no-signing (ampproject#36187) * ๐ Force transfer of `amp-consent` element to the `FixedLayer` (ampproject#36223) Fixes ampproject#36063 `amp-consent` explicitly adds itself to the `FixedLayer`, transferring itself before the iframe is loaded. On a later pass, `FixedLayer` decides that `amp-consent` is not transferrable, so it returns it to the original `<body>` element. Enabling `forceTransfer` causes the return reparenting to not occur, thus preventing the iframe from loading a second time. * ๐ฆ Update core dependencies (ampproject#35061) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * ๐ฆ Update dependency rollup to v2.58.0 (ampproject#36232) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * ๐ฆ Update dependency @octokit/rest to v18.11.4 (ampproject#36227) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * [bento][amp-iframe] Add README (ampproject#36210) * [bento][amp-iframe] changes to publish to npm (ampproject#36190) * ๐ fix broken link to Preact/React component section in various README (ampproject#36222) * ๐ release: Update self-hosting support to use amp release (ampproject#36165) * Update self-host to use amp release `amp release` copies static files and downloaded resources to supplement an `amp dist` runtime. Support custom release flavor definitions and update the amp-framework-hosting documentation. * Fix typo in documentation * Prefer accessing argv instead of passing value * Skip cleaning custom configs by default * Review suggestions * [amp-iframe] iframe viewability (ampproject#36131) * bento amp-iframe: guard effect from running without a win (ampproject#36241) * ๐ babel/terser: rename all amp privates with sentinel suffix (ampproject#36143) * configs: Separate user configs from output files (ampproject#36236) Identify user configuration files under build-system/global-configs as distinct from generated output. This will help avoid accidentally including them in the cleanup script in the future. * Fix ref issue in DisplayAsWithRef component * Update the fix Co-authored-by: Jake Fried <samouri@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> Co-authored-by: dmanek <506183+dmanek@users.noreply.github.com> Co-authored-by: Esther Kim <44627152+estherkim@users.noreply.github.com> Co-authored-by: Daniel Rozenberg <rodaniel@amp.dev> Co-authored-by: William Johnson <dethstrobe@gmail.com> Co-authored-by: Mikhail Troshev <mishanga@yandex-team.ru> Co-authored-by: Caleb Cordry <ccordry@google.com> Co-authored-by: Pascal Birchler <pascalb@google.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Allan Banaag <banaag@google.com> Co-authored-by: Amaltas Bohra <amaltas@google.com> Co-authored-by: honeybadgerdontcare <sedano@google.com> Co-authored-by: Raghu Simha <rsimha@amp.dev> Co-authored-by: qidonna <968756+qidonna@users.noreply.github.com> Co-authored-by: rebeccanthomas <64608436+rebeccanthomas@users.noreply.github.com> Co-authored-by: Corey Masanto <masanto@google.com> Co-authored-by: Philip Bell <philipbell@google.com> Co-authored-by: Alan Orozco <alanorozco@users.noreply.github.com> Co-authored-by: Matt Mower <mdmower@cmphys.com> Co-authored-by: Anurag Vasanwala <75766877+AnuragVasanwala@users.noreply.github.com>
* โจ Initial Commit * โป๏ธ Attributes mapped to props * โป๏ธ Base skeleton with references * โป๏ธ Added build functions and ๐ CSS * ๐งช Experimental commit for `Gesture` Service * โป๏ธ Added `Gesture`, `Mouse` and `Keyboard` Service `prettify` is also performed. * Added `"npm": true` for build-system compilation config Co-Authored-By: Caroline Liu <10456171+caroqliu@users.noreply.github.com> * ๐ฎ Removed validator file until rules are added Co-Authored-By: Caroline Liu <10456171+caroqliu@users.noreply.github.com> * ๐ฎ Removed unnecessary example code Co-Authored-By: Caroline Liu <10456171+caroqliu@users.noreply.github.com> * ๐ฎ Removed `copyright` header from all files Co-Authored-By: Caroline Liu <10456171+caroqliu@users.noreply.github.com> * โป๏ธ Cleanup * ๐ฎ Renoved `Services` Services should not be used in the Preact component. Co-Authored-By: Caroline Liu <10456171+caroqliu@users.noreply.github.com> * ๐งช Experiment commit, ๐ฎ Remvoed test `console.log` * ๐ Added and Formatted `JSS` & `CSS` Co-Authored-By: Caroline Liu <10456171+caroqliu@users.noreply.github.com> * ๐ Minor fixes for `JSS` * โป๏ธ `shouldHintReappear` renamed to more precise name `repeatHint` Co-Authored-By: Caroline Liu <10456171+caroqliu@users.noreply.github.com> * ๐งช Experimental Test: `DOM` APIs to `JSX` Preact component should not be creating any elements with DOM APIs. Preferring JSX instead. This is an experimental code for my storybook test. * โป๏ธ Minor fixes and Cleanup * โจ Added `seekTo` API Function * โป๏ธ Minor fix to initialise base class * โป๏ธ Added classes on the JSX node * โช Removed `CSS` Co-Authored-By: Caroline Liu <10456171+caroqliu@users.noreply.github.com> * โป๏ธ `ActionTrust` set for only user interaction `DEFAULT` is needed for user interaction whereas `LOW` events could include things like autoplaying carousels. Thus, `DEFAULT` is recommended! Co-Authored-By: Caroline Liu <10456171+caroqliu@users.noreply.github.com> * โป๏ธ Removed unnecessary initialisation and import Co-Authored-By: Caroline Liu <10456171+caroqliu@users.noreply.github.com> * โป๏ธ `ImageSlider` prefixed with `Bento` The one exception that can stay `ImageSlider` is Storybooks. So, the Storybooks are still alphabetised and searchable without getting clogged up by the `Bento` prefix noise. Co-Authored-By: Caroline Liu <10456171+caroqliu@users.noreply.github.com> * โป๏ธ Preact storybook updated with new prefix `Bento` Preact Storybook `title` should be left as `ImageSlider` so it is still alphabetised and searchable without getting clogged up by the `Bento` prefix noise. Co-Authored-By: Caroline Liu <10456171+caroqliu@users.noreply.github.com> * โป๏ธ `classList` changed with `class` Always prefer `class` to `classList`. Co-Authored-By: Caroline Liu <10456171+caroqliu@users.noreply.github.com> * โป๏ธ `initial-slider-position` type corrected to `number` Co-Authored-By: Caroline Liu <10456171+caroqliu@users.noreply.github.com> * ๐ Bug fix for `images` and `labels` Co-Authored-By: Caroline Liu <10456171+caroqliu@users.noreply.github.com> * โป๏ธ Updated storybook examples Co-Authored-By: Caroline Liu <10456171+caroqliu@users.noreply.github.com> * ๐ฎ Cleanup unnecessary storybook comment * โป๏ธ `disable-hint-reappear` renamed as `display-hint-once` in Bento `1.0` The intention is to not have an attribute with a negative name, since enabling or disabling it can be confusing to reason about. On second thought, `repeat-hint` is not a good alternative because it flips the default behaviour when omitted. Let's rename to `display-hint-once` or similar, which has the same default omitted/provided behaviour, but perhaps a clearer name. Co-Authored-By: Caroline Liu <10456171+caroqliu@users.noreply.github.com> * โช Changes to markdown reverted and moved to `0.1` Co-Authored-By: Caroline Liu <10456171+caroqliu@users.noreply.github.com> * โจ Added markdown for `1.0` Co-Authored-By: Caroline Liu <10456171+caroqliu@users.noreply.github.com> * ๐ Fix for Preact Component API Co-authored-by: Caroline Liu <10456171+caroqliu@users.noreply.github.com> * ๐ Minor bug fixes Co-authored-by: Caroline Liu <10456171+caroqliu@users.noreply.github.com> * โป๏ธ Validation check added for `percent` attribute Co-authored-by: Caroline Liu <10456171+caroqliu@users.noreply.github.com> * โป๏ธ Updated use of `DisplayAs` as a component Co-Authored-By: Caroline Liu <10456171+caroqliu@users.noreply.github.com> * โป๏ธ `BentoImageSliderApi` namespace renamed to `Api` for precise meaning Co-Authored-By: Caroline Liu <10456171+caroqliu@users.noreply.github.com> * ๐ Added `css` for `1.0`, ๐ Minor bug fixes and `prettify` Co-Authored-By: Caroline Liu <10456171+caroqliu@users.noreply.github.com> * โป๏ธ Minor fix for `percent` validation check * โป๏ธ Removed superfluous trailing argument for `parseFloat` * ๐งช Experimental Code: Image Reference Issue This commit is intended to check and resolve image reference issue mentioned in discussion: #35783 (comment) Use keyboard "left" & "right" arrow key to move bar and slide images. Also, focus on the container to enable keyboard input to the component. * Fix ref issue in DisplayAsWithRef component (#5) * tickevents: remove unused enum values (#36159) * tickevents: remove unused enum values * Remove dupe of CLS, fidv, lj1,lj2 * format * ๐ฆ Update cimg/openjdk Docker tag to v17 (#36172) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * ๐ฆ Update dependency rollup to v2.57.0 (#36134) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * ๐ฆ Update dependency @octokit/graphql to v4.7.0 (#35844) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * โป๏ธ Migrate `observeWithSharedInOb` to `observeIntersections` (#36106) * ๐ Make setup-node step consistent across gh actions (#36175) * Partially revert "๐ Parallelize `dist` steps (#35943)" (#36176) * Revert "๐ Parallelize `dist` steps (#35943)" This reverts commit 1e2c808. * Partially allow parallelization for smaller tasks * Also include `compileAllJs` in the parallelized part * (amp-lightbox-gallery): opens to selected image, resolve #35920 (#36103) removed a unlayout call that would cause the image to default to the first slide * โป๏ธ preact inob: small cleanup (#36177) * preact inob: small cleanup * also remove current * build-system: only write version.txt once per dir (#36162) * build-system: only write version.txt once * output full set of * sort the paths * write files...not directories * succinct format * bind-impl: missing ampStateEl is a user error (#36113) * Update Yandex & ADFOX amp-ad codes (#35442) * ๐งชUpdate OT token for attribution-reporting (#36181) * ๐ Add `exports` for stylesheets to `package.json` (#36027) * Add styles.css export to package.json * Conditionally add export * Use `fast-glob` * Add separate export entry for each stylesheet * window support * sort for lint Co-authored-by: Jake Fried <samouri@users.noreply.github.com> * โจ [bento][amp-iframe] Add validator rules for 1.0 (#36182) * ๐ฎ Sweep experiments older than 2021-02-01 (#35486) Sweep experiments last flipped globally up to 2021-02-01: - (2021-01-20, a9e2778) `adsense-ad-size-optimization`: 1 * UTF8 encoding/decoding library to deprecated utf8 functions in strings.h|cc (#36184) library. PiperOrigin-RevId: 398102411 Co-authored-by: Amaltas Bohra <amaltas@google.com> * Validator rollup (#36185) * cl/398081751 Use the proto message number instead of index for enums. * cl/398323481 Two-way sync for PR #36085. No-op, or fixes merge conflicts, if any. Co-authored-by: honeybadgerdontcare <sedano@google.com> * ๐ฆ Update dependency @octokit/rest to v18.11.2 (#36180) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * deps: bump bento-compiler (#36191) * ๐ฆ Update dependency @jest/core to v27.2.3 (#36189) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * ๐ฆ Update dependency esbuild to v0.12.25 (#35928) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * ๐ฆ Update linting devDependencies (#36119) * ๐ฆ Update linting devDependencies * Fix lint errors Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> Co-authored-by: Raghu Simha <rsimha@amp.dev> * ๐ฆ Update dependency axios to 0.21.2 [SECURITY] (#35999) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * ๐ฆ Update dependency esbuild to v0.13.3 (#36198) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * ๐ฆ Update dependency tar to v6.1.9 [SECURITY] (#35509) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * performance-impl: cant check ampdoc vis hidden while null (#36197) * performance-impl: cant check ampdoc vis hidden before initted * Add unit test * ๐ Add nice colors to release tagger logs (#36200) * log * comment * ๐ฆ Update core devDependencies (#36196) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * ๐ฆ Update dependency @ampproject/worker-dom to v0.32.0 (#36138) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * ๐ฆ Update dependency google-closure-library to v20210808 (#35617) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * SwG Release 0.1.22.186 (#36202) * ๐ฆ Update dependency chromedriver to v94 (#35951) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> Co-authored-by: Raghu Simha <rsimha@amp.dev> * ๐ฆ Update dependency tar to v6.1.11 (#36203) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * ๐ `bento-facebook` Documentation (#36038) * [`bento-facebook`] Update the amp-facebook.md file for both 0.1 and 1.0. Add a README.md for 1.0 bento mode. * [`bento-facebook`] Add documentation to describe the amp-facebook usage outside of valid AMP docs. * [`bento-facebook`] Add readme.md for BentoFacebook. * [`bento-facebook`] Address PR comments to update some attribute names. * [`bento-facebook`] Update CDN link to bento-facebook-1.0.js. * [`bento-facebook`] Prettify amp-facebook.md. * [`bento-facebook`] Update dead link to FB documentation to a real link. * [`bento-facebook`] Update dead links to be valid. * ๐ฎ Clean up dead amp-sidebar code within stories (#36178) * Remove amp-sidebar code from extensions/amp-story * Remove amp-sidebar visual tests from examples/visual-tests/amp-story * Remove reference to amp-sidebar from amp-story-interactive README * Remove remaining amp-sidebar logic from extensions/amp-story * Remove amp-sidebar logic from amp-story-system-layer code * Remove amp-sidebar code from amp-story-store-service.js * Remove amp-sidebar storybook JS files * A few missed deletions in test-amp-story and build-system/ caught by linter * Revert extensions/amp-sidebar/*/storybook removal from forbidden terms * Add back the amp-sidebar storybook files * Add newline at end of each storybook file * Run amp get-zindex --fix * ๐ [amp-story-panning-media] Set width on amp-img el (#36217) * Set width on amp-img el. * Add height * ๐ฆ Update dependency @octokit/rest to v18.11.3 (#36212) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * ๐ฆ Update dependency eslint-plugin-react to v7.26.1 (#36214) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * ๐ฆ Update dependency @ampproject/bento-compiler to v0.0.9 (#36225) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * โป๏ธDon't fetch crypto signature verifier in no-signing (#36187) * ๐ Force transfer of `amp-consent` element to the `FixedLayer` (#36223) Fixes #36063 `amp-consent` explicitly adds itself to the `FixedLayer`, transferring itself before the iframe is loaded. On a later pass, `FixedLayer` decides that `amp-consent` is not transferrable, so it returns it to the original `<body>` element. Enabling `forceTransfer` causes the return reparenting to not occur, thus preventing the iframe from loading a second time. * ๐ฆ Update core dependencies (#35061) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * ๐ฆ Update dependency rollup to v2.58.0 (#36232) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * ๐ฆ Update dependency @octokit/rest to v18.11.4 (#36227) Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * [bento][amp-iframe] Add README (#36210) * [bento][amp-iframe] changes to publish to npm (#36190) * ๐ fix broken link to Preact/React component section in various README (#36222) * ๐ release: Update self-hosting support to use amp release (#36165) * Update self-host to use amp release `amp release` copies static files and downloaded resources to supplement an `amp dist` runtime. Support custom release flavor definitions and update the amp-framework-hosting documentation. * Fix typo in documentation * Prefer accessing argv instead of passing value * Skip cleaning custom configs by default * Review suggestions * [amp-iframe] iframe viewability (#36131) * bento amp-iframe: guard effect from running without a win (#36241) * ๐ babel/terser: rename all amp privates with sentinel suffix (#36143) * configs: Separate user configs from output files (#36236) Identify user configuration files under build-system/global-configs as distinct from generated output. This will help avoid accidentally including them in the cleanup script in the future. * Fix ref issue in DisplayAsWithRef component * Update the fix Co-authored-by: Jake Fried <samouri@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> Co-authored-by: dmanek <506183+dmanek@users.noreply.github.com> Co-authored-by: Esther Kim <44627152+estherkim@users.noreply.github.com> Co-authored-by: Daniel Rozenberg <rodaniel@amp.dev> Co-authored-by: William Johnson <dethstrobe@gmail.com> Co-authored-by: Mikhail Troshev <mishanga@yandex-team.ru> Co-authored-by: Caleb Cordry <ccordry@google.com> Co-authored-by: Pascal Birchler <pascalb@google.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Allan Banaag <banaag@google.com> Co-authored-by: Amaltas Bohra <amaltas@google.com> Co-authored-by: honeybadgerdontcare <sedano@google.com> Co-authored-by: Raghu Simha <rsimha@amp.dev> Co-authored-by: qidonna <968756+qidonna@users.noreply.github.com> Co-authored-by: rebeccanthomas <64608436+rebeccanthomas@users.noreply.github.com> Co-authored-by: Corey Masanto <masanto@google.com> Co-authored-by: Philip Bell <philipbell@google.com> Co-authored-by: Alan Orozco <alanorozco@users.noreply.github.com> Co-authored-by: Matt Mower <mdmower@cmphys.com> Co-authored-by: Anurag Vasanwala <75766877+AnuragVasanwala@users.noreply.github.com> * Fix bento slider issues (#12) * Refactor bento amp image slider markup * Fix label styling * Fix hints and slider touch gestures * Add storybook styling for custom label and hints * Remove unneccesary code * Add comments for `containerClass` and `initLogContructor` * Update import path using alias * โป๏ธ Update alias, update AMP example * ๐ Update compilation config * ๐ Fix for `amp-img` size * โป๏ธ Update image `selector` order * โป๏ธ Minor fix passing class name * Fix bento image slider misc issues (#14) * Add slot for custom hints and fix label markup * Implement display-hint-once option and cleanup code * Fix LGTM check * Fix LGTM check * Use ContainWrapper for component wrapper * Fix circleCI checks * Add unit test cases for amp-image-slider component * Update initial position attribute in storybook * Add unit test code coverage * Fix flaky test cases * Fix unit test cases * Remove image slider 1.0 example file * Remove unused code * Remove unused code * Fix unlisten event function logic * โป๏ธ Minor fix, `lint` and `prettify` * โป๏ธ Update derived class extends using `setSuperClass` * โป๏ธ Correct dead links in `markdown` * โป๏ธ Remove `@storybook/addon-knobs` dependency from storybook * โป๏ธ Allow `src/service/timer-impl.js` dependency * โป๏ธ Update `Z_INDEX.md` * โป๏ธ Add check for `initialPosition` and `stepSize` * ๐ Update `isFiniteNumber` with `isNaN` Co-authored-by: Caroline Liu <10456171+caroqliu@users.noreply.github.com> Co-authored-by: Edi Amin <to.ediamin@gmail.com> Co-authored-by: Jake Fried <samouri@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> Co-authored-by: dmanek <506183+dmanek@users.noreply.github.com> Co-authored-by: Esther Kim <44627152+estherkim@users.noreply.github.com> Co-authored-by: Daniel Rozenberg <rodaniel@amp.dev> Co-authored-by: William Johnson <dethstrobe@gmail.com> Co-authored-by: Mikhail Troshev <mishanga@yandex-team.ru> Co-authored-by: Caleb Cordry <ccordry@google.com> Co-authored-by: Pascal Birchler <pascalb@google.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Allan Banaag <banaag@google.com> Co-authored-by: Amaltas Bohra <amaltas@google.com> Co-authored-by: honeybadgerdontcare <sedano@google.com> Co-authored-by: Raghu Simha <rsimha@amp.dev> Co-authored-by: qidonna <968756+qidonna@users.noreply.github.com> Co-authored-by: rebeccanthomas <64608436+rebeccanthomas@users.noreply.github.com> Co-authored-by: Corey Masanto <masanto@google.com> Co-authored-by: Philip Bell <philipbell@google.com> Co-authored-by: Alan Orozco <alanorozco@users.noreply.github.com> Co-authored-by: Matt Mower <mdmower@cmphys.com> Co-authored-by: Deepak Lalwani <deepak.lalwani81@gmail.com>
Issue #35920 requests to have the clicked on amp-image be the selected slide.
It appears this was an unintentional side effect of performing an unlayout on the carousel after waiting for the image transition to finish. I removed the unlayout call and added a e2e test to ensure we don't accidently break this functionality in the future.