Conversation
dmanek
commented
Sep 10, 2021
src/preact/utils.js
Outdated
| * @param {any} refTwo | ||
| * @return {function()} | ||
| */ | ||
| export function useMergeRefs(refOne, refTwo) { |
Contributor
Author
There was a problem hiding this comment.
Through https://github.com/theKashey/use-callback-ref#usemergerefs I came across react-hooks.org. This is inspired from their useForkRef implementation. Tradeoff is it only combines 2 refs, but for now it does what is required.
samouri
reviewed
Sep 10, 2021
src/preact/utils.js
Outdated
| * Combines multiple refs to pass into `ref` prop. | ||
| * @param {...any} refs | ||
| * @return {function(!Element)} | ||
| * @param {any} ref |
Member
There was a problem hiding this comment.
The any isn't valid closure 😢 . Should be *
Contributor
Author
There was a problem hiding this comment.
Updated type to {current: ?}|function()
src/preact/utils.js
Outdated
| * @return {function()} | ||
| */ | ||
| export function useMergeRefs(refOne, refTwo) { | ||
| return useMemo(() => { |
src/preact/utils.js
Outdated
| return null; | ||
| } | ||
| }; | ||
| return (element) => { |
Member
There was a problem hiding this comment.
nit: Seems even easier to take an array
export function useMergeRefs(refs) {
return useCallback(
(element) => refs.forEach((ref) => setRef(ref, element)),
refs
);
}
Contributor
Author
There was a problem hiding this comment.
Updated, except used a native for loop since @jridgewell is not a fan of forEach 🙂
src/preact/utils.js
Outdated
| * @return {function()} | ||
| */ | ||
| export function useMergeRefs(refOne, refTwo) { | ||
| return useMemo(() => { |
Member
There was a problem hiding this comment.
I think useCallback is slightly better sugar for this situation
samouri
approved these changes
Sep 10, 2021
jridgewell
approved these changes
Sep 10, 2021
rbeckthomas
pushed a commit
to rbeckthomas/amphtml
that referenced
this pull request
Sep 14, 2021
caroqliu
pushed a commit
to caroqliu/amphtml
that referenced
this pull request
Sep 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Carrying over from #35835 (comment)