🚮[Amp story] Delete desktop 3 panel and viewport warning code.#35932
Merged
processprocess merged 17 commits intoampproject:mainfrom Sep 9, 2021
Merged
🚮[Amp story] Delete desktop 3 panel and viewport warning code.#35932processprocess merged 17 commits intoampproject:mainfrom
processprocess merged 17 commits intoampproject:mainfrom
Conversation
|
Hey @gmajoulet, @newmuis! These files were changed: |
mszylkowski
reviewed
Sep 2, 2021
Contributor
There was a problem hiding this comment.
We should also update the ampdoc.css rules so the old bg color doesn't ever flash
mszylkowski
reviewed
Sep 3, 2021
Contributor
Author
Yes! Good call. |
gmajoulet
reviewed
Sep 3, 2021
gmajoulet
approved these changes
Sep 7, 2021
Member
|
could you please also clean up rules in |
calebcordry
approved these changes
Sep 7, 2021
Contributor
Author
|
cc @dmanek for OWNERS on css/ampdoc.css |
dmanek
approved these changes
Sep 8, 2021
Contributor
dmanek
left a comment
There was a problem hiding this comment.
css/ampdoc.css changes LGTM
rbeckthomas
pushed a commit
to rbeckthomas/amphtml
that referenced
this pull request
Sep 14, 2021
…oject#35932) * Remove desktop 3 panel code. * Revert rewind media. * Move background color to ampdoc.css * Fix pauseAllMedia call. * Delete unused code from checks. * Update test and template * Clean up ads css. * Clean up ads css. * Clean up unused variable. * Select pages in live-story test. * Force mobile in swipe tests. * revert newline * Set UI to mobile.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deletes desktop three panel code.
Deletes viewport warning code.
Fixes #35623