Skip to content

🐛 Bento Carousel: Fix unrecognized attributes#35696

Merged
caroqliu merged 3 commits intoampproject:mainfrom
caroqliu:unrecognized-attributes
Aug 17, 2021
Merged

🐛 Bento Carousel: Fix unrecognized attributes#35696
caroqliu merged 3 commits intoampproject:mainfrom
caroqliu:unrecognized-attributes

Conversation

@caroqliu
Copy link
Copy Markdown
Contributor

@caroqliu caroqliu commented Aug 16, 2021

This PR modifies rtl to return a string, and group to be undefined when irrelevant (as opposed to false). This fixes the following issues described in #35553:

* Warning: Received `false` for a non-boolean attribute `rtl`. If you want to write it to the DOM, pass a string instead: `rtl="false"` or `rtl={value.toString()}`. If you used to conditionally omit it with `rtl={condition && value}`, pass `rtl={condition ? value : undefined}` instead.
* Warning: Received `false` for a non-boolean attribute `group`. If you want to write it to the DOM, pass a string instead: `group="false"` or `group={value.toString()}`. If you used to conditionally omit it with `group={condition && value}`, pass `group={condition ? value : undefined}` instead.

Related to #35678

@caroqliu caroqliu merged commit 6e50aad into ampproject:main Aug 17, 2021
caroqliu added a commit to caroqliu/amphtml that referenced this pull request Aug 17, 2021
* rtl is a string

* `group` should be `undefined` when `false`

* Add unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants