🐛 Bento Carousel: Fix unrecognized attributes#35696
Merged
caroqliu merged 3 commits intoampproject:mainfrom Aug 17, 2021
Merged
🐛 Bento Carousel: Fix unrecognized attributes#35696caroqliu merged 3 commits intoampproject:mainfrom
caroqliu merged 3 commits intoampproject:mainfrom
Conversation
10 tasks
dmanek
approved these changes
Aug 16, 2021
caroqliu
added a commit
to caroqliu/amphtml
that referenced
this pull request
Aug 17, 2021
* rtl is a string * `group` should be `undefined` when `false` * Add unit tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modifies
rtlto return a string, andgroupto beundefinedwhen irrelevant (as opposed tofalse). This fixes the following issues described in #35553:Related to #35678