Skip to content

Bento: Assign overflow element to service slot#35003

Merged
caroqliu merged 2 commits intoampproject:mainfrom
caroqliu:overflow-slot
Jun 25, 2021
Merged

Bento: Assign overflow element to service slot#35003
caroqliu merged 2 commits intoampproject:mainfrom
caroqliu:overflow-slot

Conversation

@caroqliu
Copy link
Copy Markdown
Contributor

@caroqliu caroqliu commented Jun 23, 2021

This allows overflow elements to be displayed after the shadow root is attached in Bento components which use shadow DOM.

@caroqliu caroqliu requested a review from samouri June 23, 2021 19:38
@samouri
Copy link
Copy Markdown
Member

samouri commented Jun 23, 2021

@caroqliu: how did you find this bug?

@caroqliu
Copy link
Copy Markdown
Contributor Author

@caroqliu: how did you find this bug?

When verifying attemptChangeHeight behavior for the Facebook components 😄

Copy link
Copy Markdown
Member

@samouri samouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice find!

@caroqliu caroqliu merged commit ab57699 into ampproject:main Jun 25, 2021
antiphoton pushed a commit to antiphoton/amphtml that referenced this pull request Jun 25, 2021
@caroqliu caroqliu mentioned this pull request Jun 28, 2021
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants