Skip to content

✨ [Amp story] disable viewport warning when amp-story-desktop-one-panel experiment is active#34809

Merged
processprocess merged 2 commits intoampproject:mainfrom
processprocess:viewport-warnings
Jun 10, 2021
Merged

✨ [Amp story] disable viewport warning when amp-story-desktop-one-panel experiment is active#34809
processprocess merged 2 commits intoampproject:mainfrom
processprocess:viewport-warnings

Conversation

@processprocess
Copy link
Copy Markdown
Contributor

Context / Fixes #34760

@amp-owners-bot
Copy link
Copy Markdown

Hey @gmajoulet, @newmuis! These files were changed:

extensions/amp-story/1.0/amp-story.js

@processprocess processprocess requested a review from gmajoulet June 10, 2021 14:07
@processprocess processprocess merged commit 01e11e4 into ampproject:main Jun 10, 2021
@processprocess processprocess deleted the viewport-warnings branch June 10, 2021 16:52
westonruter added a commit to westonruter/amphtml that referenced this pull request Jun 11, 2021
…ebook-like-bento-version

* 'main' of github.com:ampproject/amphtml:
  minor updates + fix broken links (ampproject#34840)
  Add "wrapper": "bento" option to Bento components (ampproject#34838)
  ♻️ Move src/layout into core to unblock buildDOM for amp-layout (ampproject#34818)
  ♿ Apply `lang="en"` to relevant snippets in `test/` (ampproject#34768)
  Bento: Enable `npm` for `amp-video` (ampproject#34822)
  ✨[story-ads] Introduce new yellow segment progress bar v2 (ampproject#34804)
  SwG Release (ampproject#34825)
  📦 Update build-system devDependencies to v7.14.5 (ampproject#34802)
  Disable viewport warnings in experiment. (ampproject#34809)
  Apply lang="en" to examples/ (ampproject#34759)
  ✨ [Amp story] Scaffold desktop one panel experiment (ampproject#34755)
  ♻️ Migrate Style and DOM helpers into core/DOM + type-checking (ampproject#34681)
  🏗 Don't pull all externs into experiments (ampproject#34800)
  typechecking: remove pride as not compatible with rest of strategy (ampproject#34787)
  Fix forbidden terms to unblock `main` (ampproject#34799)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Don't trigger viewport warnings when amp-story-desktop-one-panelis active

2 participants