🏗 Use AMP's closure compiler while running validator checks#34698
Merged
rsimha merged 1 commit intoampproject:mainfrom Jun 4, 2021
rsimha:2021-06-03-ValidatorDeps
Merged
🏗 Use AMP's closure compiler while running validator checks#34698rsimha merged 1 commit intoampproject:mainfrom rsimha:2021-06-03-ValidatorDeps
rsimha merged 1 commit intoampproject:mainfrom
rsimha:2021-06-03-ValidatorDeps
Conversation
|
Hey @ampproject/wg-caching! These files were changed: |
1 task
Gregable
approved these changes
Jun 4, 2021
Member
Gregable
left a comment
There was a problem hiding this comment.
Seems worth trying. We also plan to retire the JS build within a couple months.
honeybadgerdontcare
added a commit
to honeybadgerdontcare/amphtml
that referenced
this pull request
Jun 8, 2021
…rge conflicts, if any.
Merged
twifkak
pushed a commit
that referenced
this pull request
Jun 15, 2021
* cl/377126790 Error message for invalid AMP domains. * cl/377164470 Replace goog.array API calls with native API equivalents. * cl/377366082 amp-cache-url does not require usage * cl/377966735 Two-way sync for PR #34698. No-op, or fixes merge conflicts, if any.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two advantages:
validator/each month (e.g. 📦 Update dependency google-closure-compiler to v20210601 #34691)Closes #34691