♻️ Simplify log/assert code and use core assert#34061
Merged
rcebulko merged 4 commits intoampproject:mainfrom Apr 28, 2021
Merged
♻️ Simplify log/assert code and use core assert#34061rcebulko merged 4 commits intoampproject:mainfrom
rcebulko merged 4 commits intoampproject:mainfrom
Conversation
|
Hey @jridgewell! These files were changed: |
jridgewell
approved these changes
Apr 28, 2021
This was
linked to
issues
May 12, 2021
rochapablo
pushed a commit
to rochapablo/amphtml
that referenced
this pull request
Aug 30, 2021
* Report error in core if reporting fn defined * Use base assertion fn directly in log * Move associatedElement from log to error reporting * Use concat in apply
This was referenced Oct 17, 2021
This was referenced Nov 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves detection of
error.associatedElementfromlog#prepareError_toerror-reportingwhere it is used. Simplifieslog#assertmethod in preparation for adding type assertion helpres to core.