🏗 Add catch-all type-check target and src dirs#34014
Merged
rcebulko merged 4 commits intoampproject:mainfrom Apr 26, 2021
Merged
🏗 Add catch-all type-check target and src dirs#34014rcebulko merged 4 commits intoampproject:mainfrom
rcebulko merged 4 commits intoampproject:mainfrom
Conversation
samouri
approved these changes
Apr 26, 2021
| srcGlobs: ['src/polyfills{,/**}/*.js'], | ||
| warningLevel: 'QUIET', | ||
| }, | ||
| 'src-polyfillstub': { |
Member
There was a problem hiding this comment.
nit: I'd combine this with src-polyfills
Contributor
Author
There was a problem hiding this comment.
Two steps ahead of ya: #34020
Will update whichever one gets submitted second.
rsimha
approved these changes
Apr 26, 2021
rochapablo
pushed a commit
to rochapablo/amphtml
that referenced
this pull request
Aug 30, 2021
* Add catch-all type-check target and src dirs * Drop accidental array * Drop empty arrays and extra function wrappers * Add temp comment per request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.