✨ [Amp story] [Page attachments] [Outlink] Opening Transition Element and Animation#33982
Merged
processprocess merged 34 commits intoampproject:mainfrom Apr 29, 2021
Merged
Conversation
|
Hey @gmajoulet, @newmuis, @Enriqe! These files were changed: |
mszylkowski
reviewed
Apr 26, 2021
Contributor
mszylkowski
left a comment
There was a problem hiding this comment.
Good progress! Left a couple of nits
gmajoulet
approved these changes
Apr 26, 2021
Enriqe
reviewed
Apr 26, 2021
Enriqe
reviewed
Apr 26, 2021
Contributor
Author
|
cc @ jridgewell for OWNERS on i18n. |
Enriqe
approved these changes
Apr 28, 2021
jridgewell
approved these changes
Apr 28, 2021
Contributor
jridgewell
left a comment
There was a problem hiding this comment.
Please add wg-stories as an owner of the file.
rochapablo
pushed a commit
to rochapablo/amphtml
that referenced
this pull request
Aug 30, 2021
… and Animation (ampproject#33982) * Basic styling. * Prevent default on open attachment to play pre-launch animation. * Hide img el. * Theme open preview. * Theme progress bar. * Dark theme. * Translated string and htmlrefs. * SVG * Share link icon SVG code. * Refactor no-image. * Revise comments. * Mutate element. Comment. * RTL support. * Revert line order * Null check on localization service. * Fade out CTA on open. * Show url preview on mobile only. * Remove whitespace. * Important on color variables * Remove xmlspace attr. Remove unnecessary variable. * Display none on spacer element. * Update loading bar height. * Symmetrical code for rendering link SVG. * RTL progress bar. * Prevent outlink content from being clickable unles vertical rendering. * Revert pointer events. * Add comment. * Top level consts and comments for gestures. * Remove whitespace. * Rename consts. Append class in mutate. * Lint. * lint.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context / fixes #33812
Openingstringdemo