🏗 [Story video] Add testing tools to video story for e2e and manual testing#33857
Merged
mszylkowski merged 4 commits intoampproject:mainfrom Apr 22, 2021
Merged
🏗 [Story video] Add testing tools to video story for e2e and manual testing#33857mszylkowski merged 4 commits intoampproject:mainfrom
mszylkowski merged 4 commits intoampproject:mainfrom
Conversation
gmajoulet
reviewed
Apr 21, 2021
gmajoulet
approved these changes
Apr 21, 2021
rochapablo
pushed a commit
to rochapablo/amphtml
that referenced
this pull request
Aug 30, 2021
…esting (ampproject#33857) * Added tools and manual testing * Added srcLabel * Updated comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a debug field with 3 commands:
load,unload,downgradefor videos.Eg:
1d: downgrade video 15u: unload video 53l: load video 3Also added a
spanthat shows the currentSrc for each video for easy debugging