🐛 [Story page attachment] Navigate with click on swipeup remote#33656
Merged
mszylkowski merged 6 commits intoampproject:mainfrom Apr 16, 2021
Merged
🐛 [Story page attachment] Navigate with click on swipeup remote#33656mszylkowski merged 6 commits intoampproject:mainfrom
mszylkowski merged 6 commits intoampproject:mainfrom
Conversation
Contributor
Author
|
@gmajoulet I updated the demo and code to use click with the animation, PTAL |
|
Hey @gmajoulet, @newmuis, @Enriqe! These files were changed: |
Contributor
|
Do we have a good way of testing this besides just manual tests? |
gmajoulet
reviewed
Apr 14, 2021
Contributor
Author
|
@newmuis not possible to test this automatically since it's an iOS issue |
gmajoulet
approved these changes
Apr 14, 2021
Contributor
|
Have you checked if this works with the linker and the fix your wrote back then? |
Contributor
Author
|
Swipe up doesn't work with the linker, but I created the issue #33860 to track it |
Contributor
Author
|
@choumx Waiting for the iOS team to test the updated demo story, and I'll merge as soon as they confirm it's all fine |
ampprojectbot
pushed a commit
that referenced
this pull request
Apr 18, 2021
* Make changes * Click other anchor * Use click instead of navigation service * Removed firebase debug * Renamed to match other elements (cherry picked from commit f19ff64)
This was referenced Apr 27, 2021
rochapablo
pushed a commit
to rochapablo/amphtml
that referenced
this pull request
Aug 30, 2021
…roject#33656) * Make changes * Click other anchor * Use click instead of navigation service * Removed firebase debug * Renamed to match other elements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #33709
Uses
a.click()instead of navigator to open links on new tabs.Demo at https://stories-demos-matias.web.app/examples/amp-story/attachment.html#page=page-3