✨ [amp story] [page attachments] [Inline] header UI#33601
Merged
processprocess merged 26 commits intoampproject:masterfrom Apr 2, 2021
Merged
✨ [amp story] [page attachments] [Inline] header UI#33601processprocess merged 26 commits intoampproject:masterfrom
processprocess merged 26 commits intoampproject:masterfrom
Conversation
|
Hey @gmajoulet, @newmuis, @Enriqe! These files were changed: |
868547f to
712f43c
Compare
mszylkowski
reviewed
Apr 2, 2021
mszylkowski
reviewed
Apr 2, 2021
mszylkowski
reviewed
Apr 2, 2021
mszylkowski
approved these changes
Apr 2, 2021
Contributor
mszylkowski
left a comment
There was a problem hiding this comment.
LGTM, when merging the new implementation we can simplify the template and logic.
rochapablo
pushed a commit
to rochapablo/amphtml
that referenced
this pull request
Aug 30, 2021
* RTL support. * Border radius. * Overflow text. * Remove commented out code. * Observer for header. * Sticky header on mobile. * Add whitespace in CSS * Classname. * Add comment. * Refactor repeated code in experiment conditional. * Template CSS. * Update text styles. * Close button styling. * Sticky header on desktop. * Show title and close on focus. * rebase * Remove listener variables. * Remove commented out code. * Update CSS comment. * Revert localization service line placement. * rebase * Update template * Remove commented out code. * Remove poppins.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context / Fixes #32764 & #32765
Inline attachments header UI updates.
demo
Paste
AMP.toggleExperiment('amp-story-page-attachment-ui-v2', true).to turn on experiment and see feature.