Skip to content

📦 Update core devDependencies (minor)#33443

Merged
rsimha merged 1 commit intoampproject:mainfrom
renovate-bot:renovate/core-devdependencies
Apr 27, 2021
Merged

📦 Update core devDependencies (minor)#33443
rsimha merged 1 commit intoampproject:mainfrom
renovate-bot:renovate/core-devdependencies

Conversation

@renovate-bot
Copy link
Copy Markdown
Contributor

@renovate-bot renovate-bot commented Mar 23, 2021

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
enzyme-adapter-preact-pure 3.0.0 -> 3.1.0 age adoption passing confidence
jscodeshift 0.11.0 -> 0.12.0 age adoption passing confidence
karma (source) 6.2.0 -> 6.3.2 age adoption passing confidence
sinon-chai 3.5.0 -> 3.6.0 age adoption passing confidence
terser (source) 5.6.1 -> 5.7.0 age adoption passing confidence
How to resolve breaking changes

This PR may introduce breaking changes that require manual intervention. In such cases, you will need to check out this branch, fix the cause of the breakage, and commit the fix to ensure a green CI build. To check out and update this PR, follow the steps below:

# Check out the PR branch (these steps are from GitHub)
git checkout -b renovate-bot-renovate/core-devdependencies main
git pull https://github.com/renovate-bot/amphtml.git renovate/core-devdependencies

# Directly make fixes and commit them
amp lint --fix # For lint errors in JS files
amp prettify --fix # For prettier errors in non-JS files
# Edit source code in case of new compiler warnings / errors

# Push the changes to the branch
git push git@github.com:renovate-bot/amphtml.git renovate-bot-renovate/core-devdependencies:renovate/core-devdependencies

Release Notes

preactjs/enzyme-adapter-preact-pure

v3.1.0

Compare Source

  • Add support for invoke wrapper method.
    The Preact adapter currently only supports this for full (mount) rendering
    #​135
facebook/jscodeshift

v0.12.0

Compare Source

Changed
karma-runner/karma

v6.3.2

Compare Source

Bug Fixes

v6.3.1

Compare Source

Bug Fixes

v6.3.0

Compare Source

Features
  • support asynchronous config.set() call in karma.conf.js (#​3660) (4c9097a)
domenic/sinon-chai

v3.6.0

Compare Source

  • Add support for sinon 10 (#​149)
terser/terser

v5.7.0

Compare Source

  • Several compile-time evaluation and inlining fixes
  • Allow reduce_funcs to be disabled again.
  • Add spidermonkey options to parse and format (#​974)
  • Accept {get = "default val"} and {set = "default val"} in destructuring arguments.
  • Change package.json export map to help require.resolve (#​971)
  • Improve docs
  • Fix export default of an anonymous class with extends

Configuration

📅 Schedule: "after 12am every weekday" in timezone America/Los_Angeles.

🚦 Automerge: Enabled.

♻️ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box.

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate-bot renovate-bot force-pushed the renovate/core-devdependencies branch from 802c2a1 to c8ee21e Compare March 23, 2021 22:21
@renovate-bot renovate-bot changed the title 📦 Update dependency sinon-chai to v3.6.0 📦 Update core devDependencies (minor) Mar 23, 2021
@renovate-bot renovate-bot force-pushed the renovate/core-devdependencies branch 7 times, most recently from 664033f to 173b092 Compare March 30, 2021 10:21
@renovate-bot renovate-bot force-pushed the renovate/core-devdependencies branch 5 times, most recently from 8f16cb4 to 8f3e56f Compare April 8, 2021 17:59
@renovate-bot renovate-bot force-pushed the renovate/core-devdependencies branch from 8f3e56f to f3ceb16 Compare April 9, 2021 18:36
@rsimha
Copy link
Copy Markdown
Contributor

rsimha commented Apr 9, 2021

@jridgewell This looks like a breaking change due to esbuild. Any idea what accompanying changes are needed in our code?

@rsimha rsimha requested review from jridgewell and samouri April 9, 2021 18:57
@renovate-bot renovate-bot force-pushed the renovate/core-devdependencies branch 3 times, most recently from d7bf510 to 4d58924 Compare April 12, 2021 10:17
@samouri
Copy link
Copy Markdown
Member

samouri commented Apr 12, 2021

From a cursory glance at the release notes (and error logs), I'd assume this is coming from the changes related to mixed module format support.

I'd be happy to take this on near the end of the week, but if you have spare cycles earlier feel free to @jridgewell

@renovate-bot renovate-bot force-pushed the renovate/core-devdependencies branch 3 times, most recently from 9c8d61c to 66557be Compare April 17, 2021 12:34
@samouri
Copy link
Copy Markdown
Member

samouri commented Apr 19, 2021

@jridgewell: I think this may be an error in karma-esbuild, since I cannot repro in regular builds, but it does occur when running amp unit on amp-script's unit tests.

@renovate-bot renovate-bot force-pushed the renovate/core-devdependencies branch from 66557be to 1be4e45 Compare April 21, 2021 20:11
@jridgewell
Copy link
Copy Markdown
Contributor

It's not karma-esbuild, it's just esbuild. It's seeing an import * as WorkerDOM from 'path/to/worker-dom/main.mjs', so it thinks the file is ESM. But, we're transforming our files to CJS in the babel compilation.

Trying to get babel to output ESM causes issues with:

Which are all invalid (namespace imports are not writable).

@jridgewell
Copy link
Copy Markdown
Contributor

Ughhhhhh

test/_init_tests.js
   61:8   error  Ambiguous use of a namespace import. All uses must be `describes.foo` property accesses  local/no-ambiguous-namespace-import
   61:20  error  Ambiguous use of a namespace import. All uses must be `describes.foo` property accesses  local/no-ambiguous-namespace-import
  382:30  error  Ambiguous use of a namespace import. All uses must be `coreError.foo` property accesses  local/no-ambiguous-namespace-import

✖ 3 problems (3 errors, 0 warnings)
[18:32:59]
src/context/node.js
  19:23  warning  Unexpected path "../mode" imported in restricted zone  import/no-restricted-paths

✖ 1 problem (0 errors, 1 warning)
[18:33:02]
src/preact/base-element.js
  22:43  warning  Unexpected path "../layout" imported in restricted zone                   import/no-restricted-paths
  24:31  warning  Unexpected path "../utils/media-query-props" imported in restricted zone  import/no-restricted-paths
  25:27  warning  Unexpected path "../utils/pause-helper" imported in restricted zone       import/no-restricted-paths
  42:8   warning  Unexpected path "../dom" imported in restricted zone                      import/no-restricted-paths
  44:25  warning  Unexpected path "../log" imported in restricted zone                      import/no-restricted-paths
  46:23  warning  Unexpected path "../utils/date" imported in restricted zone               import/no-restricted-paths
  47:23  warning  Unexpected path "../mode" imported in restricted zone                     import/no-restricted-paths
  49:34  warning  Unexpected path "../shadow-embed" imported in restricted zone             import/no-restricted-paths
  50:37  warning  Unexpected path "../utils/id-generator" imported in restricted zone       import/no-restricted-paths

✖ 9 problems (0 errors, 9 warnings)
[18:33:03]
src/preact/slot.js
  25:8  warning  Unexpected path "../utils/resource-container-helper" imported in restricted zone  import/no-restricted-paths

✖ 1 problem (0 errors, 1 warning)
[18:33:19]
test/unit/test-amp-inabox.js
  29:15  error  Ambiguous use of a namespace import. All uses must be `Service.foo` property accesses  local/no-ambiguous-namespace-import
  34:15  error  Ambiguous use of a namespace import. All uses must be `Service.foo` property accesses  local/no-ambiguous-namespace-import
  38:24  error  Ambiguous use of a namespace import. All uses must be `Service.foo` property accesses  local/no-ambiguous-namespace-import

✖ 3 problems (3 errors, 0 warnings)
[18:33:21]
test/unit/test-ampdoc.js
  871:22  error  Ambiguous use of a namespace import. All uses must be `dom.foo` property accesses       local/no-ambiguous-namespace-import
  877:22  error  Ambiguous use of a namespace import. All uses must be `docready.foo` property accesses  local/no-ambiguous-namespace-import
  881:22  error  Ambiguous use of a namespace import. All uses must be `docready.foo` property accesses  local/no-ambiguous-namespace-import

✖ 3 problems (3 errors, 0 warnings)
[18:33:22]
test/unit/test-cid.js
   244:26  error  Ambiguous use of a namespace import. All uses must be `cookie.foo` property accesses  local/no-ambiguous-namespace-import
   259:26  error  Ambiguous use of a namespace import. All uses must be `cookie.foo` property accesses  local/no-ambiguous-namespace-import
   279:28  error  Ambiguous use of a namespace import. All uses must be `cookie.foo` property accesses  local/no-ambiguous-namespace-import
   644:35  error  Ambiguous use of a namespace import. All uses must be `cookie.foo` property accesses  local/no-ambiguous-namespace-import
   652:35  error  Ambiguous use of a namespace import. All uses must be `cookie.foo` property accesses  local/no-ambiguous-namespace-import
   688:37  error  Ambiguous use of a namespace import. All uses must be `cookie.foo` property accesses  local/no-ambiguous-namespace-import
   714:37  error  Ambiguous use of a namespace import. All uses must be `cookie.foo` property accesses  local/no-ambiguous-namespace-import
   728:26  error  Ambiguous use of a namespace import. All uses must be `cookie.foo` property accesses  local/no-ambiguous-namespace-import
   731:35  error  Ambiguous use of a namespace import. All uses must be `cookie.foo` property accesses  local/no-ambiguous-namespace-import
   745:26  error  Ambiguous use of a namespace import. All uses must be `cookie.foo` property accesses  local/no-ambiguous-namespace-import
   748:35  error  Ambiguous use of a namespace import. All uses must be `cookie.foo` property accesses  local/no-ambiguous-namespace-import
   790:26  error  Ambiguous use of a namespace import. All uses must be `cookie.foo` property accesses  local/no-ambiguous-namespace-import
   908:20  error  Ambiguous use of a namespace import. All uses must be `cookie.foo` property accesses  local/no-ambiguous-namespace-import
   921:20  error  Ambiguous use of a namespace import. All uses must be `cookie.foo` property accesses  local/no-ambiguous-namespace-import
   937:20  error  Ambiguous use of a namespace import. All uses must be `cookie.foo` property accesses  local/no-ambiguous-namespace-import
   957:24  error  Ambiguous use of a namespace import. All uses must be `cookie.foo` property accesses  local/no-ambiguous-namespace-import
   958:22  error  Ambiguous use of a namespace import. All uses must be `cookie.foo` property accesses  local/no-ambiguous-namespace-import
   977:24  error  Ambiguous use of a namespace import. All uses must be `cookie.foo` property accesses  local/no-ambiguous-namespace-import
   978:22  error  Ambiguous use of a namespace import. All uses must be `cookie.foo` property accesses  local/no-ambiguous-namespace-import
  1015:22  error  Ambiguous use of a namespace import. All uses must be `url.foo` property accesses     local/no-ambiguous-namespace-import
  1036:22  error  Ambiguous use of a namespace import. All uses must be `url.foo` property accesses     local/no-ambiguous-namespace-import
  1057:26  error  Ambiguous use of a namespace import. All uses must be `url.foo` property accesses     local/no-ambiguous-namespace-import

✖ 22 problems (22 errors, 0 warnings)
[18:33:26]
test/unit/test-document-info.js
  29:27  error  Ambiguous use of a namespace import. All uses must be `CID.foo` property accesses  local/no-ambiguous-namespace-import

✖ 1 problem (1 error, 0 warnings)
[18:33:27]
test/unit/test-error-reporting.js
  820:41  error  Ambiguous use of a namespace import. All uses must be `analytics.foo` property accesses  local/no-ambiguous-namespace-import

✖ 1 problem (1 error, 0 warnings)
[18:33:42]
test/unit/test-navigation.js
  70:41  error  Ambiguous use of a namespace import. All uses must be `Impression.foo` property accesses  local/no-ambiguous-namespace-import

✖ 1 problem (1 error, 0 warnings)
[18:33:43]
test/unit/test-performance.js
  536:13  error  Ambiguous use of a namespace import. All uses must be `IniLoad.foo` property accesses  local/no-ambiguous-namespace-import

✖ 1 problem (1 error, 0 warnings)
[18:33:45]
test/unit/test-purifier.js
  30:9  error  Ambiguous use of a namespace import. All uses must be `urlRewrite.foo` property accesses  local/no-ambiguous-namespace-import

✖ 1 problem (1 error, 0 warnings)
[18:33:45]
test/unit/test-render-delaying-services.js
   36:44  error  Ambiguous use of a namespace import. All uses must be `service.foo` property accesses  local/no-ambiguous-namespace-import
  126:48  error  Ambiguous use of a namespace import. All uses must be `service.foo` property accesses  local/no-ambiguous-namespace-import
  130:30  error  Ambiguous use of a namespace import. All uses must be `service.foo` property accesses  local/no-ambiguous-namespace-import

✖ 3 problems (3 errors, 0 warnings)
[18:33:50]
test/unit/test-runtime.js
  373:15  error  Ambiguous use of a namespace import. All uses must be `dom.foo` property accesses     local/no-ambiguous-namespace-import
  452:15  error  Ambiguous use of a namespace import. All uses must be `dom.foo` property accesses     local/no-ambiguous-namespace-import
  616:15  error  Ambiguous use of a namespace import. All uses must be `ext.foo` property accesses     local/no-ambiguous-namespace-import
  638:11  error  Ambiguous use of a namespace import. All uses must be `styles.foo` property accesses  local/no-ambiguous-namespace-import
  657:15  error  Ambiguous use of a namespace import. All uses must be `ext.foo` property accesses     local/no-ambiguous-namespace-import
  683:17  error  Ambiguous use of a namespace import. All uses must be `styles.foo` property accesses  local/no-ambiguous-namespace-import
  702:15  error  Ambiguous use of a namespace import. All uses must be `ext.foo` property accesses     local/no-ambiguous-namespace-import
  818:11  error  Ambiguous use of a namespace import. All uses must be `styles.foo` property accesses  local/no-ambiguous-namespace-import
  836:15  error  Ambiguous use of a namespace import. All uses must be `ext.foo` property accesses     local/no-ambiguous-namespace-import
  867:17  error  Ambiguous use of a namespace import. All uses must be `styles.foo` property accesses  local/no-ambiguous-namespace-import
  886:15  error  Ambiguous use of a namespace import. All uses must be `ext.foo` property accesses     local/no-ambiguous-namespace-import

✖ 11 problems (11 errors, 0 warnings)
[18:33:54]
test/unit/test-style-installer.js
  46:46  error  Ambiguous use of a namespace import. All uses must be `rds.foo` property accesses  local/no-ambiguous-namespace-import

✖ 1 problem (1 error, 0 warnings)
[18:33:57]
test/unit/test-url-replacements.js
   487:19  error  Ambiguous use of a namespace import. All uses must be `trackPromise.foo` property accesses  local/no-ambiguous-namespace-import
   507:19  error  Ambiguous use of a namespace import. All uses must be `trackPromise.foo` property accesses  local/no-ambiguous-namespace-import
   527:19  error  Ambiguous use of a namespace import. All uses must be `trackPromise.foo` property accesses  local/no-ambiguous-namespace-import
   549:19  error  Ambiguous use of a namespace import. All uses must be `trackPromise.foo` property accesses  local/no-ambiguous-namespace-import
   568:19  error  Ambiguous use of a namespace import. All uses must be `trackPromise.foo` property accesses  local/no-ambiguous-namespace-import
   588:19  error  Ambiguous use of a namespace import. All uses must be `trackPromise.foo` property accesses  local/no-ambiguous-namespace-import
  1316:19  error  Ambiguous use of a namespace import. All uses must be `trackPromise.foo` property accesses  local/no-ambiguous-namespace-import
  1336:19  error  Ambiguous use of a namespace import. All uses must be `trackPromise.foo` property accesses  local/no-ambiguous-namespace-import
  1351:19  error  Ambiguous use of a namespace import. All uses must be `trackPromise.foo` property accesses  local/no-ambiguous-namespace-import
  1370:19  error  Ambiguous use of a namespace import. All uses must be `trackPromise.foo` property accesses  local/no-ambiguous-namespace-import
  1392:19  error  Ambiguous use of a namespace import. All uses must be `trackPromise.foo` property accesses  local/no-ambiguous-namespace-import
  1413:17  error  Ambiguous use of a namespace import. All uses must be `trackPromise.foo` property accesses  local/no-ambiguous-namespace-import

✖ 12 problems (12 errors, 0 warnings)
[18:33:57]
test/unit/test-validator-integration.js
  31:41  error  Ambiguous use of a namespace import. All uses must be `eventHelper.foo` property accesses  local/no-ambiguous-namespace-import
  32:35  error  Ambiguous use of a namespace import. All uses must be `mode.foo` property accesses         local/no-ambiguous-namespace-import
  62:15  error  Ambiguous use of a namespace import. All uses must be `eventHelper.foo` property accesses  local/no-ambiguous-namespace-import

✖ 3 problems (3 errors, 0 warnings)
[18:34:03]
test/unit/test-xhr.js
  784:29  error  Ambiguous use of a namespace import. All uses must be `mode.foo` property accesses  local/no-ambiguous-namespace-import
  788:9   error  Unexpected 'debugger' statement                                                     no-debugger
  798:29  error  Ambiguous use of a namespace import. All uses must be `mode.foo` property accesses  local/no-ambiguous-namespace-import

✖ 3 problems (3 errors, 0 warnings)
[18:34:43]
extensions/amp-date-picker/0.1/dates-list.js
   86:13  error  Ambiguous use of a namespace import. All uses must be `rrule.foo` property accesses  local/no-ambiguous-namespace-import
  116:34  error  Ambiguous use of a namespace import. All uses must be `rrule.foo` property accesses  local/no-ambiguous-namespace-import

✖ 2 problems (2 errors, 0 warnings)
[18:35:23]
extensions/amp-timeago/0.1/locales.js
  27:47  error  Ambiguous use of a namespace import. All uses must be `timeago.foo` property accesses  local/no-ambiguous-namespace-import

✖ 1 problem (1 error, 0 warnings)
[18:35:23]
extensions/amp-timeago/1.0/locales.js
  27:47  error  Ambiguous use of a namespace import. All uses must be `timeago.foo` property accesses  local/no-ambiguous-namespace-import

✖ 1 problem (1 error, 0 warnings)
[18:35:30]
src/preact/component/3p-frame.js
  25:8   warning  Unexpected path "../../3p-frame" imported in restricted zone            import/no-restricted-paths
  30:34  warning  Unexpected path "../../url" imported in restricted zone                 import/no-restricted-paths
  31:37  warning  Unexpected path "../../utils/id-generator" imported in restricted zone  import/no-restricted-paths

✖ 3 problems (0 errors, 3 warnings)
[18:35:33]
test/unit/ads/test-aduptech.js
  52:15  error  Ambiguous use of a namespace import. All uses must be `_3p.foo` property accesses  local/no-ambiguous-namespace-import

✖ 1 problem (1 error, 0 warnings)
[18:35:33]
test/unit/ads/test-csa.js
  88:24  error  Ambiguous use of a namespace import. All uses must be `_3p.foo` property accesses  local/no-ambiguous-namespace-import

✖ 1 problem (1 error, 0 warnings)
[18:35:33]
test/unit/ads/test-ssp.js
   47:18  error  Ambiguous use of a namespace import. All uses must be `_3p.foo` property accesses  local/no-ambiguous-namespace-import
   48:18  error  Ambiguous use of a namespace import. All uses must be `_3p.foo` property accesses  local/no-ambiguous-namespace-import
   49:18  error  Ambiguous use of a namespace import. All uses must be `_3p.foo` property accesses  local/no-ambiguous-namespace-import
  109:13  error  Ambiguous use of a namespace import. All uses must be `_3p.foo` property accesses  local/no-ambiguous-namespace-import
  132:18  error  Ambiguous use of a namespace import. All uses must be `_3p.foo` property accesses  local/no-ambiguous-namespace-import
  139:13  error  Ambiguous use of a namespace import. All uses must be `_3p.foo` property accesses  local/no-ambiguous-namespace-import
  159:18  error  Ambiguous use of a namespace import. All uses must be `_3p.foo` property accesses  local/no-ambiguous-namespace-import
  166:13  error  Ambiguous use of a namespace import. All uses must be `_3p.foo` property accesses  local/no-ambiguous-namespace-import
  180:13  error  Ambiguous use of a namespace import. All uses must be `_3p.foo` property accesses  local/no-ambiguous-namespace-import
  203:18  error  Ambiguous use of a namespace import. All uses must be `_3p.foo` property accesses  local/no-ambiguous-namespace-import
  212:13  error  Ambiguous use of a namespace import. All uses must be `_3p.foo` property accesses  local/no-ambiguous-namespace-import
  236:18  error  Ambiguous use of a namespace import. All uses must be `_3p.foo` property accesses  local/no-ambiguous-namespace-import
  244:13  error  Ambiguous use of a namespace import. All uses must be `_3p.foo` property accesses  local/no-ambiguous-namespace-import

✖ 13 problems (13 errors, 0 warnings)
[18:35:36]
test/unit/inabox/test-inabox-viewport.js
  97:29  error  Ambiguous use of a namespace import. All uses must be `iframeHelper.foo` property accesses  local/no-ambiguous-namespace-import

✖ 1 problem (1 error, 0 warnings)
[18:35:36]
test/unit/inabox/test-utils.js
  44:13  error  Ambiguous use of a namespace import. All uses must be `IniLoad.foo` property accesses  local/no-ambiguous-namespace-import

✖ 1 problem (1 error, 0 warnings)
[18:35:44]
ads/google/a4a/test/test-utils.js
  1145:13  error  Ambiguous use of a namespace import. All uses must be `IniLoad.foo` property accesses  local/no-ambiguous-namespace-import
  1175:13  error  Ambiguous use of a namespace import. All uses must be `IniLoad.foo` property accesses  local/no-ambiguous-namespace-import
  1206:13  error  Ambiguous use of a namespace import. All uses must be `IniLoad.foo` property accesses  local/no-ambiguous-namespace-import

✖ 3 problems (3 errors, 0 warnings)
[18:35:45]
extensions/amp-3q-player/0.1/test/test-amp-3q-player.js
  211:37  error  Ambiguous use of a namespace import. All uses must be `dom.foo` property accesses  local/no-ambiguous-namespace-import
  217:37  error  Ambiguous use of a namespace import. All uses must be `dom.foo` property accesses  local/no-ambiguous-namespace-import

✖ 2 problems (2 errors, 0 warnings)
[18:35:48]
extensions/amp-a4a/0.1/test/test-amp-a4a.js
   179:22  error  Ambiguous use of a namespace import. All uses must be `mode.foo` property accesses                local/no-ambiguous-namespace-import
   194:22  error  Ambiguous use of a namespace import. All uses must be `mode.foo` property accesses                local/no-ambiguous-namespace-import
   725:9   error  Ambiguous use of a namespace import. All uses must be `analytics.foo` property accesses           local/no-ambiguous-namespace-import
   755:9   error  Ambiguous use of a namespace import. All uses must be `analytics.foo` property accesses           local/no-ambiguous-namespace-import
   773:9   error  Ambiguous use of a namespace import. All uses must be `analytics.foo` property accesses           local/no-ambiguous-namespace-import
   788:9   error  Ambiguous use of a namespace import. All uses must be `analyticsExtension.foo` property accesses  local/no-ambiguous-namespace-import
   805:9   error  Ambiguous use of a namespace import. All uses must be `analyticsExtension.foo` property accesses  local/no-ambiguous-namespace-import
   961:11  error  Ambiguous use of a namespace import. All uses must be `analytics.foo` property accesses           local/no-ambiguous-namespace-import
   981:11  error  Ambiguous use of a namespace import. All uses must be `analytics.foo` property accesses           local/no-ambiguous-namespace-import
  1076:11  error  Ambiguous use of a namespace import. All uses must be `analytics.foo` property accesses           local/no-ambiguous-namespace-import
  1195:11  error  Ambiguous use of a namespace import. All uses must be `analytics.foo` property accesses           local/no-ambiguous-namespace-import
  2982:24  error  Ambiguous use of a namespace import. All uses must be `mode.foo` property accesses                local/no-ambiguous-namespace-import
  2991:24  error  Ambiguous use of a namespace import. All uses must be `mode.foo` property accesses                local/no-ambiguous-namespace-import
  3001:24  error  Ambiguous use of a namespace import. All uses must be `mode.foo` property accesses                local/no-ambiguous-namespace-import
  3012:24  error  Ambiguous use of a namespace import. All uses must be `mode.foo` property accesses                local/no-ambiguous-namespace-import
  3023:24  error  Ambiguous use of a namespace import. All uses must be `mode.foo` property accesses                local/no-ambiguous-namespace-import
  3034:24  error  Ambiguous use of a namespace import. All uses must be `mode.foo` property accesses                local/no-ambiguous-namespace-import
  3197:24  error  Ambiguous use of a namespace import. All uses must be `analytics.foo` property accesses           local/no-ambiguous-namespace-import
  3244:9   error  Ambiguous use of a namespace import. All uses must be `analytics.foo` property accesses           local/no-ambiguous-namespace-import

✖ 19 problems (19 errors, 0 warnings)
[18:35:51]
extensions/amp-access/0.1/test/test-amp-access-client.js
  80:26  error  Ambiguous use of a namespace import. All uses must be `mode.foo` property accesses  local/no-ambiguous-namespace-import

✖ 1 problem (1 error, 0 warnings)
[18:35:52]
extensions/amp-access/0.1/test/test-amp-access-server-jwt.js
  133:41  error  Ambiguous use of a namespace import. All uses must be `DocumentFetcher.foo` property accesses  local/no-ambiguous-namespace-import

✖ 1 problem (1 error, 0 warnings)
[18:35:52]
extensions/amp-access/0.1/test/test-amp-access-server.js
  103:41  error  Ambiguous use of a namespace import. All uses must be `DocumentFetcher.foo` property accesses  local/no-ambiguous-namespace-import

✖ 1 problem (1 error, 0 warnings)
[18:35:58]
extensions/amp-ad/0.1/test/test-amp-ad-3p-impl.js
  133:26  error  Ambiguous use of a namespace import. All uses must be `adCid.foo` property accesses    local/no-ambiguous-namespace-import
  146:26  error  Ambiguous use of a namespace import. All uses must be `adCid.foo` property accesses    local/no-ambiguous-namespace-import
  160:17  error  Ambiguous use of a namespace import. All uses must be `consent.foo` property accesses  local/no-ambiguous-namespace-import
  163:17  error  Ambiguous use of a namespace import. All uses must be `consent.foo` property accesses  local/no-ambiguous-namespace-import
  166:17  error  Ambiguous use of a namespace import. All uses must be `consent.foo` property accesses  local/no-ambiguous-namespace-import

✖ 5 problems (5 errors, 0 warnings)
[18:35:58]
extensions/amp-ad/0.1/test/test-amp-ad-ui.js
   42:24  error  Ambiguous use of a namespace import. All uses must be `adHelper.foo` property accesses  local/no-ambiguous-namespace-import
   70:28  error  Ambiguous use of a namespace import. All uses must be `dom.foo` property accesses       local/no-ambiguous-namespace-import
  101:28  error  Ambiguous use of a namespace import. All uses must be `dom.foo` property accesses       local/no-ambiguous-namespace-import
  134:28  error  Ambiguous use of a namespace import. All uses must be `dom.foo` property accesses       local/no-ambiguous-namespace-import

✖ 4 problems (4 errors, 0 warnings)
[18:36:01]
extensions/amp-ad-network-adsense-impl/0.1/test/test-amp-ad-network-adsense-impl.js
  1612:11  error  Ambiguous use of a namespace import. All uses must be `experiments.foo` property accesses  local/no-ambiguous-namespace-import

✖ 1 problem (1 error, 0 warnings)
[18:36:04]
extensions/amp-ad-network-doubleclick-impl/0.1/test/test-amp-ad-network-doubleclick-impl.js
  1680:24  error  Ambiguous use of a namespace import. All uses must be `bytesUtils.foo` property accesses  local/no-ambiguous-namespace-import

✖ 1 problem (1 error, 0 warnings)
[18:36:08]
extensions/amp-analytics/0.1/test/test-analytics-root.js
  102:33  error  Ambiguous use of a namespace import. All uses must be `IniLoad.foo` property accesses  local/no-ambiguous-namespace-import
  123:33  error  Ambiguous use of a namespace import. All uses must be `IniLoad.foo` property accesses  local/no-ambiguous-namespace-import

✖ 2 problems (2 errors, 0 warnings)
[18:36:09]
extensions/amp-analytics/0.1/test/test-cookie-writer.js
   43:24  error  Ambiguous use of a namespace import. All uses must be `cookie.foo` property accesses  local/no-ambiguous-namespace-import
  262:36  error  Ambiguous use of a namespace import. All uses must be `cookie.foo` property accesses  local/no-ambiguous-namespace-import
  534:27  error  Ambiguous use of a namespace import. All uses must be `cookie.foo` property accesses  local/no-ambiguous-namespace-import
  554:27  error  Ambiguous use of a namespace import. All uses must be `cookie.foo` property accesses  local/no-ambiguous-namespace-import

✖ 4 problems (4 errors, 0 warnings)
[18:36:11]
extensions/amp-analytics/0.1/test/test-linker-manager.js
  456:15  error  Ambiguous use of a namespace import. All uses must be `Cookies.foo` property accesses  local/no-ambiguous-namespace-import
  488:24  error  Ambiguous use of a namespace import. All uses must be `Cookies.foo` property accesses  local/no-ambiguous-namespace-import

✖ 2 problems (2 errors, 0 warnings)
[18:36:12]
extensions/amp-analytics/0.1/test/test-requests.js
   76:26  error  Ambiguous use of a namespace import. All uses must be `log.foo` property accesses             local/no-ambiguous-namespace-import
  622:13  error  Ambiguous use of a namespace import. All uses must be `ResourceTiming.foo` property accesses  local/no-ambiguous-namespace-import

✖ 2 problems (2 errors, 0 warnings)
[18:36:22]
extensions/amp-auto-ads/0.1/test/test-ad-tracker.js
  34:22  error  Ambiguous use of a namespace import. All uses must be `Utils.foo` property accesses  local/no-ambiguous-namespace-import

✖ 1 problem (1 error, 0 warnings)
[18:36:30]
extensions/amp-brightcove/0.1/test/test-amp-brightcove.js
  303:15  error  Ambiguous use of a namespace import. All uses must be `consent.foo` property accesses  local/no-ambiguous-namespace-import
  306:15  error  Ambiguous use of a namespace import. All uses must be `consent.foo` property accesses  local/no-ambiguous-namespace-import
  308:24  error  Ambiguous use of a namespace import. All uses must be `consent.foo` property accesses  local/no-ambiguous-namespace-import

✖ 3 problems (3 errors, 0 warnings)
[18:36:33]
extensions/amp-carousel/0.2/test/test-type-slides.js
  540:43  error  Ambiguous use of a namespace import. All uses must be `Listen.foo` property accesses  local/no-ambiguous-namespace-import
  553:43  error  Ambiguous use of a namespace import. All uses must be `Listen.foo` property accesses  local/no-ambiguous-namespace-import

✖ 2 problems (2 errors, 0 warnings)
[18:36:40]
extensions/amp-consent/0.1/test/test-cookie-writer.js
   40:24  error  Ambiguous use of a namespace import. All uses must be `cookie.foo` property accesses  local/no-ambiguous-namespace-import
  223:36  error  Ambiguous use of a namespace import. All uses must be `cookie.foo` property accesses  local/no-ambiguous-namespace-import
  400:27  error  Ambiguous use of a namespace import. All uses must be `cookie.foo` property accesses  local/no-ambiguous-namespace-import
  420:27  error  Ambiguous use of a namespace import. All uses must be `cookie.foo` property accesses  local/no-ambiguous-namespace-import

✖ 4 problems (4 errors, 0 warnings)
[18:36:46]
extensions/amp-experiment/0.1/test/test-amp-experiment.js
  138:37  error  Ambiguous use of a namespace import. All uses must be `variant.foo` property accesses  local/no-ambiguous-namespace-import

✖ 1 problem (1 error, 0 warnings)
[18:36:48]
extensions/amp-experiment/1.0/test/test-amp-experiment.js
   94:37  error  Ambiguous use of a namespace import. All uses must be `variant.foo` property accesses          local/no-ambiguous-namespace-import
  168:15  error  Ambiguous use of a namespace import. All uses must be `applyExperiment.foo` property accesses  local/no-ambiguous-namespace-import
  192:17  error  Ambiguous use of a namespace import. All uses must be `applyExperiment.foo` property accesses  local/no-ambiguous-namespace-import

✖ 3 problems (3 errors, 0 warnings)
[18:36:50]
extensions/amp-form/0.1/test/test-amp-form-textarea.js
  181:17  error  Ambiguous use of a namespace import. All uses must be `eventHelper.foo` property accesses  local/no-ambiguous-namespace-import

✖ 1 problem (1 error, 0 warnings)
[18:36:54]
extensions/amp-form/0.1/test/test-amp-form.js
   90:19  error  Ambiguous use of a namespace import. All uses must be `xhrUtils.foo` property accesses  local/no-ambiguous-namespace-import
  279:29  error  Ambiguous use of a namespace import. All uses must be `xhrUtils.foo` property accesses  local/no-ambiguous-namespace-import
  280:29  error  Ambiguous use of a namespace import. All uses must be `xhrUtils.foo` property accesses  local/no-ambiguous-namespace-import
  281:30  error  Ambiguous use of a namespace import. All uses must be `xhrUtils.foo` property accesses  local/no-ambiguous-namespace-import
  352:29  error  Ambiguous use of a namespace import. All uses must be `xhrUtils.foo` property accesses  local/no-ambiguous-namespace-import
  353:29  error  Ambiguous use of a namespace import. All uses must be `xhrUtils.foo` property accesses  local/no-ambiguous-namespace-import
  354:30  error  Ambiguous use of a namespace import. All uses must be `xhrUtils.foo` property accesses  local/no-ambiguous-namespace-import
  427:29  error  Ambiguous use of a namespace import. All uses must be `xhrUtils.foo` property accesses  local/no-ambiguous-namespace-import
  428:29  error  Ambiguous use of a namespace import. All uses must be `xhrUtils.foo` property accesses  local/no-ambiguous-namespace-import
  429:30  error  Ambiguous use of a namespace import. All uses must be `xhrUtils.foo` property accesses  local/no-ambiguous-namespace-import

✖ 10 problems (10 errors, 0 warnings)
[18:37:01]
extensions/amp-image-lightbox/0.1/test/test-amp-image-lightbox.js
  242:40  error  Ambiguous use of a namespace import. All uses must be `dom.foo` property accesses  local/no-ambiguous-namespace-import

✖ 1 problem (1 error, 0 warnings)
[18:37:02]
extensions/amp-jwplayer/0.1/test/test-amp-jwplayer.js
  222:37  error  Ambiguous use of a namespace import. All uses must be `utils.foo` property accesses  local/no-ambiguous-namespace-import
  232:37  error  Ambiguous use of a namespace import. All uses must be `utils.foo` property accesses  local/no-ambiguous-namespace-import

✖ 2 problems (2 errors, 0 warnings)
[18:37:03]
extensions/amp-lightbox/0.1/test/test-amp-lightbox.js
  157:43  error  Ambiguous use of a namespace import. All uses must be `dom.foo` property accesses  local/no-ambiguous-namespace-import
  177:43  error  Ambiguous use of a namespace import. All uses must be `dom.foo` property accesses  local/no-ambiguous-namespace-import
  208:43  error  Ambiguous use of a namespace import. All uses must be `dom.foo` property accesses  local/no-ambiguous-namespace-import
  284:43  error  Ambiguous use of a namespace import. All uses must be `dom.foo` property accesses  local/no-ambiguous-namespace-import
  305:43  error  Ambiguous use of a namespace import. All uses must be `dom.foo` property accesses  local/no-ambiguous-namespace-import

✖ 5 problems (5 errors, 0 warnings)
[18:37:08]
extensions/amp-minute-media-player/0.1/test/test-amp-minute-media-player.js
  162:37  error  Ambiguous use of a namespace import. All uses must be `dom.foo` property accesses  local/no-ambiguous-namespace-import
  168:37  error  Ambiguous use of a namespace import. All uses must be `dom.foo` property accesses  local/no-ambiguous-namespace-import

✖ 2 problems (2 errors, 0 warnings)
[18:37:09]
extensions/amp-mustache/0.1/test/test-amp-mustache.js
   35:9   error  Ambiguous use of a namespace import. All uses must be `service.foo` property accesses    local/no-ambiguous-namespace-import
  604:28  error  Ambiguous use of a namespace import. All uses must be `sanitizer.foo` property accesses  local/no-ambiguous-namespace-import

✖ 2 problems (2 errors, 0 warnings)
[18:37:09]
extensions/amp-mustache/0.2/test/test-amp-mustache.js
  35:9  error  Ambiguous use of a namespace import. All uses must be `service.foo` property accesses  local/no-ambiguous-namespace-import

✖ 1 problem (1 error, 0 warnings)
[18:37:10]
extensions/amp-next-page/0.1/test/test-amp-next-page.js
  67:44  error  Ambiguous use of a namespace import. All uses must be `DocFetcher.foo` property accesses  local/no-ambiguous-namespace-import

✖ 1 problem (1 error, 0 warnings)
[18:37:11]
extensions/amp-nexxtv-player/0.1/test/test-amp-nexxtv-player.js
  117:24  error  Ambiguous use of a namespace import. All uses must be `consent.foo` property accesses  local/no-ambiguous-namespace-import

✖ 1 problem (1 error, 0 warnings)
[18:37:11]
extensions/amp-o2-player/0.1/test/test-amp-o2-player.js
  206:17  error  Ambiguous use of a namespace import. All uses must be `iframeHelper.foo` property accesses  local/no-ambiguous-namespace-import
  248:17  error  Ambiguous use of a namespace import. All uses must be `iframeHelper.foo` property accesses  local/no-ambiguous-namespace-import
  293:17  error  Ambiguous use of a namespace import. All uses must be `iframeHelper.foo` property accesses  local/no-ambiguous-namespace-import

✖ 3 problems (3 errors, 0 warnings)
[18:37:11]
extensions/amp-ooyala-player/0.1/test/test-amp-ooyala.js
  177:37  error  Ambiguous use of a namespace import. All uses must be `dom.foo` property accesses  local/no-ambiguous-namespace-import
  183:37  error  Ambiguous use of a namespace import. All uses must be `dom.foo` property accesses  local/no-ambiguous-namespace-import

✖ 2 problems (2 errors, 0 warnings)
[18:37:13]
extensions/amp-render/1.0/test/test-amp-render.js
  117:9   error  Ambiguous use of a namespace import. All uses must be `BatchedJsonModule.foo` property accesses  local/no-ambiguous-namespace-import
  192:9   error  Ambiguous use of a namespace import. All uses must be `BatchedJsonModule.foo` property accesses  local/no-ambiguous-namespace-import
  229:9   error  Ambiguous use of a namespace import. All uses must be `BatchedJsonModule.foo` property accesses  local/no-ambiguous-namespace-import
  272:9   error  Ambiguous use of a namespace import. All uses must be `BatchedJsonModule.foo` property accesses  local/no-ambiguous-namespace-import
  328:15  error  Ambiguous use of a namespace import. All uses must be `BatchedJsonModule.foo` property accesses  local/no-ambiguous-namespace-import

✖ 5 problems (5 errors, 0 warnings)
[18:37:19]
extensions/amp-skimlinks/0.1/test/test-amp-skimlinks.js
   69:17  error  Ambiguous use of a namespace import. All uses must be `DocumentReady.foo` property accesses      local/no-ambiguous-namespace-import
   80:17  error  Ambiguous use of a namespace import. All uses must be `DocumentReady.foo` property accesses      local/no-ambiguous-namespace-import
   90:17  error  Ambiguous use of a namespace import. All uses must be `DocumentReady.foo` property accesses      local/no-ambiguous-namespace-import
   92:25  error  Ambiguous use of a namespace import. All uses must be `SkimOptionsModule.foo` property accesses  local/no-ambiguous-namespace-import
  140:28  error  Ambiguous use of a namespace import. All uses must be `chunkModule.foo` property accesses        local/no-ambiguous-namespace-import

✖ 5 problems (5 errors, 0 warnings)
[18:37:19]
extensions/amp-skimlinks/0.1/test/test-link-rewriter.js
   46:22  error  Ambiguous use of a namespace import. All uses must be `chunkModule.foo` property accesses  local/no-ambiguous-namespace-import
  443:22  error  Ambiguous use of a namespace import. All uses must be `chunkModule.foo` property accesses  local/no-ambiguous-namespace-import

✖ 2 problems (2 errors, 0 warnings)
[18:37:20]
extensions/amp-smartlinks/0.1/test/test-amp-smartlinks.js
  47:15  error  Ambiguous use of a namespace import. All uses must be `DocumentReady.foo` property accesses    local/no-ambiguous-namespace-import
  57:25  error  Ambiguous use of a namespace import. All uses must be `LinkmateOptions.foo` property accesses  local/no-ambiguous-namespace-import
  82:25  error  Ambiguous use of a namespace import. All uses must be `LinkmateOptions.foo` property accesses  local/no-ambiguous-namespace-import

✖ 3 problems (3 errors, 0 warnings)
[18:37:20]
extensions/amp-smartlinks/0.1/test/test-linkmate.js
  59:15  error  Ambiguous use of a namespace import. All uses must be `DocumentReady.foo` property accesses  local/no-ambiguous-namespace-import

✖ 1 problem (1 error, 0 warnings)
[18:37:23]
extensions/amp-story/1.0/test/test-amp-story-embedded-component.js
  83:7  error  Ambiguous use of a namespace import. All uses must be `analyticsApi.foo` property accesses  local/no-ambiguous-namespace-import

✖ 1 problem (1 error, 0 warnings)
[18:37:25]
extensions/amp-story/1.0/test/test-amp-story.js
  567:26  error  Ambiguous use of a namespace import. All uses must be `consent.foo` property accesses  local/no-ambiguous-namespace-import
  606:26  error  Ambiguous use of a namespace import. All uses must be `consent.foo` property accesses  local/no-ambiguous-namespace-import
  645:26  error  Ambiguous use of a namespace import. All uses must be `consent.foo` property accesses  local/no-ambiguous-namespace-import
  965:17  error  Ambiguous use of a namespace import. All uses must be `utils.foo` property accesses    local/no-ambiguous-namespace-import

✖ 4 problems (4 errors, 0 warnings)
[18:37:27]
extensions/amp-story-auto-ads/0.1/test/test-amp-story-auto-ads.js
  386:46  error  Ambiguous use of a namespace import. All uses must be `storyEvents.foo` property accesses  local/no-ambiguous-namespace-import

✖ 1 problem (1 error, 0 warnings)
[18:37:27]
extensions/amp-story-auto-ads/0.1/test/test-story-ad-analytics.js
  38:38  error  Ambiguous use of a namespace import. All uses must be `analyticsApi.foo` property accesses  local/no-ambiguous-namespace-import

✖ 1 problem (1 error, 0 warnings)
[18:37:28]
extensions/amp-story-auto-ads/0.1/test/test-story-ad-page.js
  391:56  error  Ambiguous use of a namespace import. All uses must be `dom.foo` property accesses      local/no-ambiguous-namespace-import
  477:15  error  Ambiguous use of a namespace import. All uses must be `service.foo` property accesses  local/no-ambiguous-namespace-import

✖ 2 problems (2 errors, 0 warnings)
[18:37:30]
extensions/amp-subscriptions/0.1/test/test-amp-subscriptions.js
  136:13  error  Ambiguous use of a namespace import. All uses must be `utilsStory.foo` property accesses  local/no-ambiguous-namespace-import

✖ 1 problem (1 error, 0 warnings)
[18:37:30]
extensions/amp-subscriptions/0.1/test/test-analytics.js
  77:37  error  Ambiguous use of a namespace import. All uses must be `AmpAnalytics.foo` property accesses  local/no-ambiguous-namespace-import

✖ 1 problem (1 error, 0 warnings)
[18:37:32]
extensions/amp-tiktok/0.1/test/test-amp-tiktok.js
  42:15  error  Ambiguous use of a namespace import. All uses must be `dom.foo` property accesses  local/no-ambiguous-namespace-import

✖ 1 problem (1 error, 0 warnings)
[18:37:37]
extensions/amp-viewer-integration/0.1/test/test-highlight-handler.js
  138:24  error  Ambiguous use of a namespace import. All uses must be `docready.foo` property accesses  local/no-ambiguous-namespace-import

✖ 1 problem (1 error, 0 warnings)
[18:37:38]
extensions/amp-web-push/0.1/test/test-web-push-service.js
  94:24  error  Ambiguous use of a namespace import. All uses must be `mode.foo` property accesses  local/no-ambiguous-namespace-import

✖ 1 problem (1 error, 0 warnings)
[18:37:38]
extensions/amp-wistia-player/0.1/test/test-amp-wistia-player.js
  113:37  error  Ambiguous use of a namespace import. All uses must be `dom.foo` property accesses  local/no-ambiguous-namespace-import
  119:37  error  Ambiguous use of a namespace import. All uses must be `dom.foo` property accesses  local/no-ambiguous-namespace-import

✖ 2 problems (2 errors, 0 warnings)
[18:37:43]
extensions/amp-lightbox-gallery/0.1/test/integration/test-amp-lightbox-gallery.js
   56:11  error  Ambiguous use of a namespace import. All uses must be `analytics.foo` property accesses  local/no-ambiguous-namespace-import
  221:11  error  Ambiguous use of a namespace import. All uses must be `analytics.foo` property accesses  local/no-ambiguous-namespace-import

@samouri
Copy link
Copy Markdown
Member

samouri commented Apr 25, 2021

Trying to get babel to output ESM causes issues with:

Can we force esbuild to understand it as cjs instead? Or rename from .mjs to js after babel transforms it to cjs. Might be the path of least resistance compared to making our tests esm compatible.

@rsimha
Copy link
Copy Markdown
Contributor

rsimha commented Apr 27, 2021

@jridgewell @samouri esbuild upgrades will now be done via separate PRs so they can be tested in isolation, and so that other upgrades needn't be held back (see #34031). Let's continue this discussion in #34035. (Sorry, I know it breaks the continuity of the comments in this PR.)

@renovate-bot renovate-bot force-pushed the renovate/core-devdependencies branch 3 times, most recently from 38cbf2f to 6df9150 Compare April 27, 2021 18:28
@renovate-bot renovate-bot force-pushed the renovate/core-devdependencies branch from 6df9150 to b0f1b5e Compare April 27, 2021 19:38
@rsimha rsimha merged commit a57332f into ampproject:main Apr 27, 2021
@renovate-bot renovate-bot deleted the renovate/core-devdependencies branch April 27, 2021 20:45
@rsimha rsimha mentioned this pull request May 5, 2021
1 task
rochapablo pushed a commit to rochapablo/amphtml that referenced this pull request Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants