Skip to content

✨ Validator: Enable the i-amphtml-binding attribute for faster amp-bind#32901

Merged
jridgewell merged 2 commits intoampproject:masterfrom
jridgewell:validator-amp-bind
Feb 25, 2021
Merged

✨ Validator: Enable the i-amphtml-binding attribute for faster amp-bind#32901
jridgewell merged 2 commits intoampproject:masterfrom
jridgewell:validator-amp-bind

Conversation

@jridgewell
Copy link
Copy Markdown
Contributor

@jridgewell jridgewell commented Feb 25, 2021

See #32851

Part of #27590

@amp-owners-bot amp-owners-bot bot requested a review from amaltas February 25, 2021 06:20
@amp-owners-bot
Copy link
Copy Markdown

amp-owners-bot bot commented Feb 25, 2021

Hey @ampproject/wg-caching! These files were changed:

validator/validator-main.protoascii

@honeybadgerdontcare
Copy link
Copy Markdown
Contributor

@jridgewell Any reason not to also set value: "" so it's only ever just i-amphtml-binding?

@jridgewell
Copy link
Copy Markdown
Contributor Author

Any reason not to also set value: "" so it's only ever just i-amphtml-binding?

Done.

@jridgewell jridgewell merged commit 7b1ade5 into ampproject:master Feb 25, 2021
@jridgewell jridgewell deleted the validator-amp-bind branch February 25, 2021 21:30
caoboxiao added a commit to caoboxiao/amphtml that referenced this pull request Mar 1, 2021
caoboxiao added a commit to caoboxiao/amphtml that referenced this pull request Mar 1, 2021
caoboxiao added a commit that referenced this pull request Mar 1, 2021
* cl/358923348 Add warning when the CDATA for application/ld+json can not be parsed

* cl/358925534 Simplify creation of ParsedTagSpecs.

* cl/359076457 Add support for multiple dispatch keys in a single tagspec. Use this new feature to improve the amp-nested-menu error.

* cl/359398014 Allow <style amp-onerror> for AMP documents.

* cl/359808644 Revision bump for #32901

Co-authored-by: honeybadgerdontcare <sedano@google.com>
Co-authored-by: Greg Grothaus <greggrothaus@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants