✨ [bento][amp-sidebar] Allow esc key to close sidebar#32431
Merged
krdwan merged 6 commits intoampproject:masterfrom Feb 18, 2021
Merged
✨ [bento][amp-sidebar] Allow esc key to close sidebar#32431krdwan merged 6 commits intoampproject:masterfrom
krdwan merged 6 commits intoampproject:masterfrom
Conversation
krdwan
commented
Feb 4, 2021
krdwan
commented
Feb 4, 2021
dvoytenko
suggested changes
Feb 4, 2021
caroqliu
reviewed
Feb 4, 2021
caroqliu
approved these changes
Feb 5, 2021
23 tasks
caroqliu
approved these changes
Feb 16, 2021
Contributor
caroqliu
left a comment
There was a problem hiding this comment.
left a couple comments, looks so much more clear now!
krdwan
commented
Feb 17, 2021
dvoytenko
suggested changes
Feb 17, 2021
dvoytenko
approved these changes
Feb 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sidebar tracker: #31366
Update 2/10
This is dependent on: #32584
On hold until dependency is completed!
When sidebar opens, attach an eventListener to check for the 'esc' key being pressed and close the sidebar if it is pressed.
How does this work?
eventListenergets attached once sidebar element is rendered (done viauseEffect(async))closeapi will handle reversing the animation