✨ [bento][amp-sidebar] Update animations to obey APIs mid-animation#32584
Merged
krdwan merged 14 commits intoampproject:masterfrom Feb 12, 2021
Merged
✨ [bento][amp-sidebar] Update animations to obey APIs mid-animation#32584krdwan merged 14 commits intoampproject:masterfrom
krdwan merged 14 commits intoampproject:masterfrom
Conversation
This was referenced Feb 10, 2021
dvoytenko
suggested changes
Feb 10, 2021
dvoytenko
suggested changes
Feb 10, 2021
dvoytenko
suggested changes
Feb 11, 2021
dvoytenko
suggested changes
Feb 11, 2021
caroqliu
reviewed
Feb 11, 2021
dvoytenko
approved these changes
Feb 11, 2021
caroqliu
approved these changes
Feb 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sidebar tracker: #31366
open,close,toggleshould update / reverse animations mid-animationPrior to this change, if
closewas called while the sidebar was animating open, it would snap to a fully opened state and begin closing. Now, it will begin animating closed from whatever position it was in (so it will reverse from the current position). This can be done multiple times in a single animation by repeatedly callingclose,open,close, ... ortoggle,toggle,toggle....Works in both directions: opening and closing.
How it works:
reverse()on it when the sidebar is told to animate in a different direction.to do: