🐛 Hiding story education layer when viewport warning layer is visible#32230
Merged
gmajoulet merged 5 commits intoampproject:masterfrom Feb 1, 2021
Merged
🐛 Hiding story education layer when viewport warning layer is visible#32230gmajoulet merged 5 commits intoampproject:masterfrom
gmajoulet merged 5 commits intoampproject:masterfrom
Conversation
|
Hey @gmajoulet, @newmuis, @Enriqe! These files were changed: |
Contributor
|
I like how this solution fixes the messaging priority UX as well as fixing the display issue. The Since the user has to interact with the education layer to dismiss it, it will still be there when the window is resized: |
processprocess
approved these changes
Feb 1, 2021
Contributor
processprocess
left a comment
There was a problem hiding this comment.
Approved with one nit.
zaparent
pushed a commit
to zaparent/amphtml
that referenced
this pull request
Feb 1, 2021
…ampproject#32230) * hiding education layer when warning layer is visible * removing force-education-layer code * fixing z-index * nit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modified z-index so the viewport warning layer covers all the content when it is displayed. Once the user has resized their viewport, they will see the education and/or the story content.
Changed z-index on
amp-story-unsupported-browser-layerfor same reason.Screencapture after education layer was changed:
Context / Fixes #30294.