Skip to content

🏗 Remove npm publishing boilerplate from src/purifier#32125

Merged
rsimha merged 1 commit intoampproject:masterfrom
rsimha:2021-01-22-Purifier
Jan 22, 2021
Merged

🏗 Remove npm publishing boilerplate from src/purifier#32125
rsimha merged 1 commit intoampproject:masterfrom
rsimha:2021-01-22-Purifier

Conversation

@rsimha
Copy link
Copy Markdown
Contributor

@rsimha rsimha commented Jan 22, 2021

Since @ampproject/purifier is only used within amphtml by directly importing from src/purifier/, I have deprecated the npm package based on the discussion at #32090 (comment). This PR cleans up all the publishing boilerplate.

This will eliminate the maintenance burden of its package dependencies.

image

@rsimha rsimha requested review from jridgewell and samouri January 22, 2021 16:42
@rsimha rsimha self-assigned this Jan 22, 2021
Copy link
Copy Markdown
Member

@samouri samouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing follow through! Thanks @rsimha

@rsimha rsimha merged commit cffccff into ampproject:master Jan 22, 2021
@rsimha rsimha deleted the 2021-01-22-Purifier branch January 22, 2021 17:57
micajuine-ho pushed a commit to micajuine-ho/amphtml that referenced this pull request Jan 25, 2021
PetrBlaha pushed a commit to PetrBlaha/amphtml that referenced this pull request Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants